From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id M/VxJGY2I2qrxTYAWB0awg (envelope-from ) for ; Fri, 05 Jun 2026 16:49:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BR4w2eBO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 71C3F1E024; Fri, 05 Jun 2026 16:49:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9751C1E024 for ; Fri, 05 Jun 2026 16:49:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 126D94BAD17A for ; Fri, 5 Jun 2026 20:49:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 126D94BAD17A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BR4w2eBO Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 8DA864BA2E06 for ; Fri, 5 Jun 2026 20:49:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8DA864BA2E06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8DA864BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780692553; cv=none; b=X74TzwuBpWifLGvNEB0ZAM3EMzyzH+hTT9+jhvyDC7jzX1vti+LNIZl14ZkxefvBn6Xx1LFBKpM6qh5fhPi5c/TW4kgX6Y930GVR2lGR9BE3PXoMHPugWAwymEBiM16sWuZhgsDOc7JM81peLrRhzFQroY5ILA2rV8Ax4GG1Tkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780692553; c=relaxed/simple; bh=HdNPN4aExFSJjUpuV/AyQ33RJ/ypZImgGQyLGb2wEtY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EF7gKuK3ri0iX8dH5cVZf3YAntcTCOt0WvL6RX9zR6B+8qQJAcGKngpV4pqHWDJcKgJyWraG/3v+87HEZDtkhygSGlqg04osH1oSKceT53fWCUBQW/gShb+PKdB0+X9LOZSsQkkIgQSXKBDXwAM2YibzMiDx3xHiwd4BUvzcBMs= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BR4w2eBO reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DA864BA2E06 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id VaTJwiA6hjgweVbTcwkQKr; Fri, 05 Jun 2026 20:49:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id VbTbwsdokWBahVbTbwfmdz; Fri, 05 Jun 2026 20:49:11 +0000 X-Authority-Analysis: v=2.4 cv=Y9D4sgeN c=1 sm=1 tr=0 ts=6a233647 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=23utoldEtsOR26clqdYA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tKt1oL6Vs1wm6IPJSo18TopE2pix6g3VojtfLhf9JkM=; b=BR4w2eBODG/XCuawX48A3JD+jd HUxI3EAC3WYIIjTl8uBEOSmACb6CVdIWHr7aWk/viWc4K1QlLBKL3uEJCnsoMdKHuQTjFCn0O84nW M/or6BaIJUoMloeK01dcvsQ1e; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:55420 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wVbTb-00000002SZc-0qca; Fri, 05 Jun 2026 14:49:11 -0600 From: Tom Tromey To: Matthieu Longo Cc: Tom Tromey , Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name In-Reply-To: (Matthieu Longo's message of "Wed, 3 Jun 2026 17:30:38 +0100") References: <20260526160459.270322-1-matthieu.longo@arm.com> <87fr3e6sdp.fsf@tromey.com> <11b35b46-7e18-471a-94e2-91fef5b287d2@arm.com> <87tsrr5vtl.fsf@tromey.com> <62841b2c-9d0e-4efc-9b26-ca9bfd8787b9@arm.com> <87ldd35php.fsf@tromey.com> <87zf1ixzc9.fsf@redhat.com> <87cxye5pn0.fsf@tromey.com> <65c7d5c1-37ba-4e49-8d2a-800421075fb2@arm.com> <87o6hts2q0.fsf@redhat.com> <87fr35hvjb.fsf@tromey.com> X-Attribution: Tom Date: Fri, 05 Jun 2026 14:49:09 -0600 Message-ID: <87pl24hfwa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wVbTb-00000002SZc-0qca X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:55420 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIDHaCmjsVUK6bUG+fB+Mohf6WautGIwPljKR/ekb9t4dPqP44lNQaINPq7ap8Tl2p5VVC/IiKNeg7MUFltkEUMowH5DqHgpfcWDov4J6wkZ0ax14mvM +VsMe9kUhTzX8Uz8WfYd6ZrJ5cuI6DQSHiMwQ3mbyTsWoeJWn+m8MS5wlUA91cnfumxsTPbJZXFwxg48iVA7yM1+EM5uafa6t1Q= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Matthieu" == Matthieu Longo writes: Matthieu> + /* This helper should be used for cases when the called CPython function Matthieu> + informs the caller that an error occurred, and a Python error was set. */ Matthieu> + auto handle_err = [&]() -> std::string Matthieu> + { Matthieu> + gdbpy_print_stack (); Matthieu> + PyErr_Clear (); Matthieu> + return NO_TYPE_NAME; The PyErr_Clear is redundant as gdbpy_print_stack guarantees that no error is set when it returns. Tom