From: Tom Tromey <tromey@redhat.com>
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2
Date: Wed, 28 Nov 2012 21:55:00 -0000 [thread overview]
Message-ID: <87mwy18kb2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50AD0303.5030100@arm.com> (Marcus Shawcroft's message of "Wed, 21 Nov 2012 16:36:19 +0000")
>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@arm.com> writes:
Marcus> This patch contains the base AArch64 port for GDB.
I'm not really the right person to comment on most of this series, but I
did have a couple questions.
Marcus> +#include <inttypes.h>
Is this strictly necessary?
Marcus> + tdep = xcalloc (1, sizeof (struct gdbarch_tdep));
Marcus> + gdbarch = gdbarch_alloc (&info, tdep);
[... fill it in ...]
I wonder if you plan to port the various gdbarch 'sdt' bits.
It usually isn't very hard; e.g., see arm-linux-tdep.c.
Tom
next prev parent reply other threads:[~2012-11-28 21:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 16:36 Marcus Shawcroft
2012-11-28 21:55 ` Tom Tromey [this message]
2012-11-29 13:01 ` Marcus Shawcroft
2012-11-29 15:35 ` Tom Tromey
2012-11-29 21:52 ` Joel Brobecker
2012-11-30 8:26 ` Marcus Shawcroft
2012-11-30 18:31 ` Tom Tromey
2012-12-03 16:26 ` Marcus Shawcroft
2012-12-23 6:34 ` Joel Brobecker
2012-12-23 6:47 ` Joel Brobecker
2013-01-07 14:22 ` [PATCH 1/5] aarch64-tdep basic port Marcus Shawcroft
2013-01-13 6:48 ` Joel Brobecker
2013-01-13 7:07 ` Joel Brobecker
2013-01-18 19:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwy18kb2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox