From: Marcus Shawcroft <marcus.shawcroft@arm.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2
Date: Fri, 30 Nov 2012 08:26:00 -0000 [thread overview]
Message-ID: <50B86D4D.2000102@arm.com> (raw)
In-Reply-To: <87ip8o7789.fsf@fleche.redhat.com>
On 29/11/12 15:35, Tom Tromey wrote:
> Marcus> +#include <inttypes.h>
>
> Tom> Is this strictly necessary?
>
> Marcus> The port uses the output specifier PRIx64 and friends in various
> Marcus> places hence the inclusion of inttypes.h. There are a number of
> Marcus> places in the existing gdb and gdbserver code base where such marcros
> Marcus> are already used.
>
> I don't see any other places in gdb itself.
OK, The instance I noticed was in common:
./common/buffer.c:152: sprintf (str, "%" PRIx64,
.. but I see no reason not to switch to CORE_ADDR and
core_addr_to_string_nz() for each of these PRIx64. I'll make this
change in the next spin of the patches.
/Marcus
next prev parent reply other threads:[~2012-11-30 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 16:36 Marcus Shawcroft
2012-11-28 21:55 ` Tom Tromey
2012-11-29 13:01 ` Marcus Shawcroft
2012-11-29 15:35 ` Tom Tromey
2012-11-29 21:52 ` Joel Brobecker
2012-11-30 8:26 ` Marcus Shawcroft [this message]
2012-11-30 18:31 ` Tom Tromey
2012-12-03 16:26 ` Marcus Shawcroft
2012-12-23 6:34 ` Joel Brobecker
2012-12-23 6:47 ` Joel Brobecker
2013-01-07 14:22 ` [PATCH 1/5] aarch64-tdep basic port Marcus Shawcroft
2013-01-13 6:48 ` Joel Brobecker
2013-01-13 7:07 ` Joel Brobecker
2013-01-18 19:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B86D4D.2000102@arm.com \
--to=marcus.shawcroft@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox