Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2

[Marcus Shawcroft <marcus.shawcroft@arm.com>]

On 28/11/12 21:54, Tom Tromey wrote:
>>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@arm.com> writes:
>
> Marcus> This patch contains the base AArch64 port for GDB.
>
> I'm not really the right person to comment on most of this series, but I
> did have a couple questions.
>
> Marcus> +#include <inttypes.h>

> Is this strictly necessary?

The port uses the output specifier PRIx64 and friends in various places 
hence the inclusion of inttypes.h.  There are a number of places in the 
existing gdb and gdbserver code base where such marcros are already used.

> Marcus> +  tdep = xcalloc (1, sizeof (struct gdbarch_tdep));
> Marcus> +  gdbarch = gdbarch_alloc (&info, tdep);
> [... fill it in ...]
>
> I wonder if you plan to port the various gdbarch 'sdt' bits.
> It usually isn't very hard; e.g., see arm-linux-tdep.c.

We don;t have any concrete plans to work on system tap at the moment.

Cheers
/Marcus