Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2

[Tom Tromey <tromey@redhat.com>]

>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@arm.com> writes:

Marcus> +#include <inttypes.h>

Tom> Is this strictly necessary?

Marcus> The port uses the output specifier PRIx64 and friends in various
Marcus> places hence the inclusion of inttypes.h.  There are a number of
Marcus> places in the existing gdb and gdbserver code base where such marcros
Marcus> are already used.

I don't see any other places in gdb itself.

According to gnulib, PRIx64 is not portable.  It is simpler to just use
the existing gdb infrastructure here, but if you really want inttypes.h,
then you need to use the appropriate gnulib module or something like that.

Tom> I wonder if you plan to port the various gdbarch 'sdt' bits.
Tom> It usually isn't very hard; e.g., see arm-linux-tdep.c.

Marcus> We don;t have any concrete plans to work on system tap at the moment.

The name choice here isn't super -- this has nothing to do with
SystemTap per se.  It is a gdb feature for interacting with static
probes.  A couple of gdb features are implemented this way on
glibc-based systems; if you don't do this work, then your port will have
reduced functionality.

Tom