Re: [PATCH 1/5] aarch64-tdep basic port.

[Pedro Alves <palves@redhat.com>]

On 01/07/2013 02:21 PM, Marcus Shawcroft wrote:
> +/* Implement the "skip_prologue" gdbarch method.  */
> +
> +static CORE_ADDR
> +aarch64_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
> +{
> +  unsigned long inst;
> +  CORE_ADDR skip_pc;
> +  CORE_ADDR func_addr, limit_pc;
> +  struct symtab_and_line sal;
> +
> +  /* If we're in a dummy frame, don't even try to skip the prologue.  */
> +  if (deprecated_pc_in_call_dummy (gdbarch, pc))
> +    return pc;
> +

Do you really need this?  We no longer had any calls in
the tree, and this adds back one.

> +static int
> +aarch64_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc)
> +{
> +  CORE_ADDR jb_addr;
> +  char buf[X_REGISTER_SIZE];

gdb_byte

> +/* Implment the "pseudo_register_read" gdbarch method.  */

Typo "implement".

> +
> +static enum register_status
> +aarch64_pseudo_read (struct gdbarch *gdbarch, struct regcache *regcache,
> +		     int regnum, gdb_byte *buf)
> +{

Can you convert this use the newer pseudo_register_read_value ?
Should be pretty simple.

I'm a little lost navigating this thread (due to the subject
issue, and patches as replies to patches), and on the status
of the patches.  Was there a documentation patch?  You'll
need to document the new commands in the manual (we document
even internal commands), and the new remote protocol target
description features.

-- 
Pedro Alves