From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24484 invoked by alias); 18 Jan 2013 19:09:40 -0000 Received: (qmail 24462 invoked by uid 22791); 18 Jan 2013 19:09:37 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 19:09:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0IJ9Ms3001769 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Jan 2013 14:09:22 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0IJ9KFI002118; Fri, 18 Jan 2013 14:09:21 -0500 Message-ID: <50F99DDF.7080901@redhat.com> Date: Fri, 18 Jan 2013 19:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Marcus Shawcroft CC: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/5] aarch64-tdep basic port. References: <50AD0303.5030100@arm.com> <50BCD288.4030109@arm.com> <20121223063407.GK5370@adacore.com> <50EAD9FF.4040303@arm.com> In-Reply-To: <50EAD9FF.4040303@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00449.txt.bz2 On 01/07/2013 02:21 PM, Marcus Shawcroft wrote: > +/* Implement the "skip_prologue" gdbarch method. */ > + > +static CORE_ADDR > +aarch64_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) > +{ > + unsigned long inst; > + CORE_ADDR skip_pc; > + CORE_ADDR func_addr, limit_pc; > + struct symtab_and_line sal; > + > + /* If we're in a dummy frame, don't even try to skip the prologue. */ > + if (deprecated_pc_in_call_dummy (gdbarch, pc)) > + return pc; > + Do you really need this? We no longer had any calls in the tree, and this adds back one. > +static int > +aarch64_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc) > +{ > + CORE_ADDR jb_addr; > + char buf[X_REGISTER_SIZE]; gdb_byte > +/* Implment the "pseudo_register_read" gdbarch method. */ Typo "implement". > + > +static enum register_status > +aarch64_pseudo_read (struct gdbarch *gdbarch, struct regcache *regcache, > + int regnum, gdb_byte *buf) > +{ Can you convert this use the newer pseudo_register_read_value ? Should be pretty simple. I'm a little lost navigating this thread (due to the subject issue, and patches as replies to patches), and on the status of the patches. Was there a documentation patch? You'll need to document the new commands in the manual (we document even internal commands), and the new remote protocol target description features. -- Pedro Alves