From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10944 invoked by alias); 29 Nov 2012 15:35:27 -0000 Received: (qmail 10749 invoked by uid 22791); 29 Nov 2012 15:35:26 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 15:35:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qATFZ9bX008253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Nov 2012 10:35:17 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qATFZ239013085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 29 Nov 2012 10:35:07 -0500 From: Tom Tromey To: Marcus Shawcroft Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2 References: <50AD0303.5030100@arm.com> <87mwy18kb2.fsf@fleche.redhat.com> <50B75C86.3080909@arm.com> Date: Thu, 29 Nov 2012 15:35:00 -0000 In-Reply-To: <50B75C86.3080909@arm.com> (Marcus Shawcroft's message of "Thu, 29 Nov 2012 13:00:54 +0000") Message-ID: <87ip8o7789.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00867.txt.bz2 >>>>> "Marcus" == Marcus Shawcroft writes: Marcus> +#include Tom> Is this strictly necessary? Marcus> The port uses the output specifier PRIx64 and friends in various Marcus> places hence the inclusion of inttypes.h. There are a number of Marcus> places in the existing gdb and gdbserver code base where such marcros Marcus> are already used. I don't see any other places in gdb itself. According to gnulib, PRIx64 is not portable. It is simpler to just use the existing gdb infrastructure here, but if you really want inttypes.h, then you need to use the appropriate gnulib module or something like that. Tom> I wonder if you plan to port the various gdbarch 'sdt' bits. Tom> It usually isn't very hard; e.g., see arm-linux-tdep.c. Marcus> We don;t have any concrete plans to work on system tap at the moment. The name choice here isn't super -- this has nothing to do with SystemTap per se. It is a gdb feature for interacting with static probes. A couple of gdb features are implemented this way on glibc-based systems; if you don't do this work, then your port will have reduced functionality. Tom