From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14535 invoked by alias); 29 Nov 2012 13:01:06 -0000 Received: (qmail 14524 invoked by uid 22791); 29 Nov 2012 13:01:05 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 13:01:00 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 29 Nov 2012 13:00:57 +0000 Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 29 Nov 2012 13:00:55 +0000 Message-ID: <50B75C86.3080909@arm.com> Date: Thu, 29 Nov 2012 13:01:00 -0000 From: Marcus Shawcroft User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2 References: <50AD0303.5030100@arm.com> <87mwy18kb2.fsf@fleche.redhat.com> In-Reply-To: <87mwy18kb2.fsf@fleche.redhat.com> X-MC-Unique: 112112913005703501 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00849.txt.bz2 On 28/11/12 21:54, Tom Tromey wrote: >>>>>> "Marcus" =3D=3D Marcus Shawcroft writes: > > Marcus> This patch contains the base AArch64 port for GDB. > > I'm not really the right person to comment on most of this series, but I > did have a couple questions. > > Marcus> +#include > Is this strictly necessary? The port uses the output specifier PRIx64 and friends in various places=20 hence the inclusion of inttypes.h. There are a number of places in the=20 existing gdb and gdbserver code base where such marcros are already used. > Marcus> + tdep =3D xcalloc (1, sizeof (struct gdbarch_tdep)); > Marcus> + gdbarch =3D gdbarch_alloc (&info, tdep); > [... fill it in ...] > > I wonder if you plan to port the various gdbarch 'sdt' bits. > It usually isn't very hard; e.g., see arm-linux-tdep.c. We don;t have any concrete plans to work on system tap at the moment. Cheers /Marcus