From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96473-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2074 invoked by alias); 30 Nov 2012 08:26:22 -0000
Received: (qmail 2061 invoked by uid 22791); 30 Nov 2012 08:26:19 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 08:26:14 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 30 Nov 2012 08:26:08 +0000
Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Fri, 30 Nov 2012 08:24:46 +0000
Message-ID: <50B86D4D.2000102@arm.com>
Date: Fri, 30 Nov 2012 08:26:00 -0000
From: Marcus Shawcroft <marcus.shawcroft@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2
References: <50AD0303.5030100@arm.com> <87mwy18kb2.fsf@fleche.redhat.com> <50B75C86.3080909@arm.com> <87ip8o7789.fsf@fleche.redhat.com>
In-Reply-To: <87ip8o7789.fsf@fleche.redhat.com>
X-MC-Unique: 112113008260802801
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00911.txt.bz2

On 29/11/12 15:35, Tom Tromey wrote:
> Marcus> +#include <inttypes.h>
>
> Tom> Is this strictly necessary?
>
> Marcus> The port uses the output specifier PRIx64 and friends in various
> Marcus> places hence the inclusion of inttypes.h.  There are a number of
> Marcus> places in the existing gdb and gdbserver code base where such mar=
cros
> Marcus> are already used.
>
> I don't see any other places in gdb itself.

OK, The instance I noticed was in common:

./common/buffer.c:152:		      sprintf (str, "%" PRIx64,

.. but I see no reason not to switch to CORE_ADDR and=20
core_addr_to_string_nz() for each of these PRIx64.  I'll make this=20
change in the next spin of the patches.

/Marcus