From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96393-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26951 invoked by alias); 28 Nov 2012 21:55:11 -0000
Received: (qmail 26940 invoked by uid 22791); 28 Nov 2012 21:55:10 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 21:55:02 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qASLsw2d017249	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 28 Nov 2012 16:54:58 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qASLsvrX026459	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 28 Nov 2012 16:54:57 -0500
From: Tom Tromey <tromey@redhat.com>
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] AArch64 GDB and GDBSERVER Port V2
References: <50AD0303.5030100@arm.com>
Date: Wed, 28 Nov 2012 21:55:00 -0000
In-Reply-To: <50AD0303.5030100@arm.com> (Marcus Shawcroft's message of "Wed,	21 Nov 2012 16:36:19 +0000")
Message-ID: <87mwy18kb2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00831.txt.bz2

>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@arm.com> writes:

Marcus> This patch contains the base AArch64 port for GDB.

I'm not really the right person to comment on most of this series, but I
did have a couple questions.

Marcus> +#include <inttypes.h>

Is this strictly necessary?

Marcus> +  tdep = xcalloc (1, sizeof (struct gdbarch_tdep));
Marcus> +  gdbarch = gdbarch_alloc (&info, tdep);
[... fill it in ...]

I wonder if you plan to port the various gdbarch 'sdt' bits.
It usually isn't very hard; e.g., see arm-linux-tdep.c.

Tom