Re: [RFC] One more ARI related fix

Re: [RFC] One more ARI related fix

[Eli Zaretskii]

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Fri, 18 Mar 2011 15:49:09 +0100
> 
> +		  error(_("Cannot subscript requested type."));

This should be

		  error (_("Cannot subscript requested type."));

RE: [RFC] One more ARI related fix

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Eli Zaretskii
> Envoyé : vendredi 18 mars 2011 15:59
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFC] One more ARI related fix
> 
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Date: Fri, 18 Mar 2011 15:49:09 +0100
> >
> > +		  error(_("Cannot subscript requested type."));
> 
> This should be
> 
> 		  error (_("Cannot subscript requested type."));

  Whoops, this probably explains what happened
in the first place...


Revised patch below:

2011-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>

	* python/py-value.c (valpy_getitem): Fix formatting of error
function
	call.

Index: python/py-value.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-value.c,v
retrieving revision 1.23
diff -u -p -r1.23 py-value.c
--- python/py-value.c	28 Feb 2011 19:38:34 -0000	1.23
+++ python/py-value.c	18 Mar 2011 14:40:15 -0000
@@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject 
 	      type = check_typedef (value_type (tmp));
 	      if (TYPE_CODE (type) != TYPE_CODE_ARRAY
 		  && TYPE_CODE (type) != TYPE_CODE_PTR)
-		  error( _("Cannot subscript requested type."));
+		  error (_("Cannot subscript requested type."));
 	      else
 		res_val = value_subscript (tmp, value_as_long (idx));
 	    }

RE: [RFC] One more ARI related fix

[Pierre Muller]

> -----Message d'origine-----
> De : Joel Brobecker [mailto:brobecker@adacore.com]
> Envoyé : vendredi 18 mars 2011 17:06
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFC] One more ARI related fix
> 
> >   Is the ChangeLog OK as is, or should I mention the ARI rule?
> 
> I don't think you really need to mention the ARI rule... The ChangeLog
> is mostly about "what" you did, so your entry seems fine to me.

  Thanks, patch committed.

  And thanks again to Eli who
pointed out that the formatting of my first version was 
wrong...

Pierre

Re: [RFC] One more ARI related fix

[Joel Brobecker]

>   Is the ChangeLog OK as is, or should I mention the ARI rule?

I don't think you really need to mention the ARI rule... The ChangeLog
is mostly about "what" you did, so your entry seems fine to me.

> 2011-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* python/py-value.c (valpy_getitem): Fix formatting of error function
> 	call.
> 
> Index: python/py-value.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/python/py-value.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 py-value.c
> --- python/py-value.c	28 Feb 2011 19:38:34 -0000	1.23
> +++ python/py-value.c	18 Mar 2011 14:40:15 -0000
> @@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject 
>  	      type = check_typedef (value_type (tmp));
>  	      if (TYPE_CODE (type) != TYPE_CODE_ARRAY
>  		  && TYPE_CODE (type) != TYPE_CODE_PTR)
> -		  error( _("Cannot subscript requested type."));
> +		  error(_("Cannot subscript requested type."));
>  	      else
>  		res_val = value_subscript (tmp, value_as_long (idx));
>  	    }

-- 
Joel

[RFC] One more ARI related fix

[Pierre Muller]

  The wrong formatting of error function call 
in valpy_getitem function leads to a false
ARI warning.
  The patch could probably gt in as obvious
as it just is a formatting patch,
but my question is if I should mention
the reason that made me submit that patch?

  This patch, together with a separate commit
to gdb_ari.sh, in order not to require _() around simple "%s" 
string should remove all markup ARI warnings.

  Is the ChangeLog OK as is,
or should I mention the ARI rule?

Pierre



2011-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>

	* python/py-value.c (valpy_getitem): Fix formatting of error
function
	call.

Index: python/py-value.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-value.c,v
retrieving revision 1.23
diff -u -p -r1.23 py-value.c
--- python/py-value.c	28 Feb 2011 19:38:34 -0000	1.23
+++ python/py-value.c	18 Mar 2011 14:40:15 -0000
@@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject 
 	      type = check_typedef (value_type (tmp));
 	      if (TYPE_CODE (type) != TYPE_CODE_ARRAY
 		  && TYPE_CODE (type) != TYPE_CODE_PTR)
-		  error( _("Cannot subscript requested type."));
+		  error(_("Cannot subscript requested type."));
 	      else
 		res_val = value_subscript (tmp, value_as_long (idx));
 	    }