Re: [RFC] One more ARI related fix

Joel Brobecker
2011-03-18T16:06:35Z

> Is the ChangeLog OK as is, or should I mention the ARI rule?

I don't think you really need to mention the ARI rule... The ChangeLog
is mostly about "what" you did, so your entry seems fine to me.

> 2011-03-18 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * python/py-value.c (valpy_getitem): Fix formatting of error function
> call.
>
> Index: python/py-value.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/python/py-value.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 py-value.c
> --- python/py-value.c 28 Feb 2011 19:38:34 -0000 1.23
> +++ python/py-value.c 18 Mar 2011 14:40:15 -0000
> @@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject
> type = check_typedef (value_type (tmp));
> if (TYPE_CODE (type) != TYPE_CODE_ARRAY
> && TYPE_CODE (type) != TYPE_CODE_PTR)
> - error( _("Cannot subscript requested type."));
> + error(_("Cannot subscript requested type."));
> else
> res_val = value_subscript (tmp, value_as_long (idx));
> }

--
Joel