[RFC] One more ARI related fix

Pierre Muller
2011-03-18T14:49:17Z

The wrong formatting of error function call
in valpy_getitem function leads to a false
ARI warning.
The patch could probably gt in as obvious
as it just is a formatting patch,
but my question is if I should mention
the reason that made me submit that patch?

This patch, together with a separate commit
to gdb_ari.sh, in order not to require _() around simple "%s"
string should remove all markup ARI warnings.

Is the ChangeLog OK as is,
or should I mention the ARI rule?

Pierre

2011-03-18 Pierre Muller <muller@ics.u-strasbg.fr>

* python/py-value.c (valpy_getitem): Fix formatting of error
function
call.

Index: python/py-value.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-value.c,v
retrieving revision 1.23
diff -u -p -r1.23 py-value.c
--- python/py-value.c 28 Feb 2011 19:38:34 -0000 1.23
+++ python/py-value.c 18 Mar 2011 14:40:15 -0000
@@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject
type = check_typedef (value_type (tmp));
if (TYPE_CODE (type) != TYPE_CODE_ARRAY
&& TYPE_CODE (type) != TYPE_CODE_PTR)
- error( _("Cannot subscript requested type."));
+ error(_("Cannot subscript requested type."));
else
res_val = value_subscript (tmp, value_as_long (idx));
}