From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12651 invoked by alias); 18 Mar 2011 14:49:17 -0000 Received: (qmail 12633 invoked by uid 22791); 18 Mar 2011 14:49:15 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 14:49:10 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2IEn7Qc094185 for ; Fri, 18 Mar 2011 15:49:08 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [130.79.204.10]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2IEn766056338 for ; Fri, 18 Mar 2011 15:49:07 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2IEn7KK045077 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Fri, 18 Mar 2011 15:49:07 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFC] One more ARI related fix Date: Fri, 18 Mar 2011 15:18:00 -0000 Message-ID: <001801cbe57b$a3ad41d0$eb07c570$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00919.txt.bz2 The wrong formatting of error function call in valpy_getitem function leads to a false ARI warning. The patch could probably gt in as obvious as it just is a formatting patch, but my question is if I should mention the reason that made me submit that patch? This patch, together with a separate commit to gdb_ari.sh, in order not to require _() around simple "%s" string should remove all markup ARI warnings. Is the ChangeLog OK as is, or should I mention the ARI rule? Pierre 2011-03-18 Pierre Muller * python/py-value.c (valpy_getitem): Fix formatting of error function call. Index: python/py-value.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-value.c,v retrieving revision 1.23 diff -u -p -r1.23 py-value.c --- python/py-value.c 28 Feb 2011 19:38:34 -0000 1.23 +++ python/py-value.c 18 Mar 2011 14:40:15 -0000 @@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject type = check_typedef (value_type (tmp)); if (TYPE_CODE (type) != TYPE_CODE_ARRAY && TYPE_CODE (type) != TYPE_CODE_PTR) - error( _("Cannot subscript requested type.")); + error(_("Cannot subscript requested type.")); else res_val = value_subscript (tmp, value_as_long (idx)); }