From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79809-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3022 invoked by alias); 18 Mar 2011 16:06:35 -0000
Received: (qmail 3008 invoked by uid 22791); 18 Mar 2011 16:06:34 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 16:06:29 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id DDC922BAAEE;	Fri, 18 Mar 2011 12:06:27 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id zYAQKOXMY8pG; Fri, 18 Mar 2011 12:06:27 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id B12FE2BAADE;	Fri, 18 Mar 2011 12:06:27 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 29BA51459AD; Fri, 18 Mar 2011 09:06:24 -0700 (PDT)
Date: Fri, 18 Mar 2011 16:30:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] One more ARI related fix
Message-ID: <20110318160624.GB2520@adacore.com>
References: <001801cbe57b$a3ad41d0$eb07c570$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001801cbe57b$a3ad41d0$eb07c570$@muller@ics-cnrs.unistra.fr>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00922.txt.bz2

>   Is the ChangeLog OK as is, or should I mention the ARI rule?

I don't think you really need to mention the ARI rule... The ChangeLog
is mostly about "what" you did, so your entry seems fine to me.

> 2011-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* python/py-value.c (valpy_getitem): Fix formatting of error function
> 	call.
> 
> Index: python/py-value.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/python/py-value.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 py-value.c
> --- python/py-value.c	28 Feb 2011 19:38:34 -0000	1.23
> +++ python/py-value.c	18 Mar 2011 14:40:15 -0000
> @@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject 
>  	      type = check_typedef (value_type (tmp));
>  	      if (TYPE_CODE (type) != TYPE_CODE_ARRAY
>  		  && TYPE_CODE (type) != TYPE_CODE_PTR)
> -		  error( _("Cannot subscript requested type."));
> +		  error(_("Cannot subscript requested type."));
>  	      else
>  		res_val = value_subscript (tmp, value_as_long (idx));
>  	    }

-- 
Joel