From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32241 invoked by alias); 18 Mar 2011 15:18:03 -0000 Received: (qmail 32225 invoked by uid 22791); 18 Mar 2011 15:18:02 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 15:17:57 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2IFHpHD098816 ; Fri, 18 Mar 2011 16:17:51 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms5.u-strasbg.fr [130.79.204.14]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2IFHp4P006515 ; Fri, 18 Mar 2011 16:17:51 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2IFHopM054194 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 18 Mar 2011 16:17:51 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" Cc: References: <001801cbe57b$a3ad41d0$eb07c570$%muller@ics-cnrs.unistra.fr> <83fwqksce5.fsf@gnu.org> In-Reply-To: <83fwqksce5.fsf@gnu.org> Subject: RE: [RFC] One more ARI related fix Date: Fri, 18 Mar 2011 16:11:00 -0000 Message-ID: <001b01cbe57f$a6fac250$f4f046f0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00921.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Eli Zaretskii > Envoy=E9=A0: vendredi 18 mars 2011 15:59 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC] One more ARI related fix >=20 > > From: "Pierre Muller" > > Date: Fri, 18 Mar 2011 15:49:09 +0100 > > > > + error(_("Cannot subscript requested type.")); >=20 > This should be >=20 > error (_("Cannot subscript requested type.")); Whoops, this probably explains what happened in the first place... Revised patch below: 2011-03-18 Pierre Muller * python/py-value.c (valpy_getitem): Fix formatting of error function call. Index: python/py-value.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/python/py-value.c,v retrieving revision 1.23 diff -u -p -r1.23 py-value.c --- python/py-value.c 28 Feb 2011 19:38:34 -0000 1.23 +++ python/py-value.c 18 Mar 2011 14:40:15 -0000 @@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject=20 type =3D check_typedef (value_type (tmp)); if (TYPE_CODE (type) !=3D TYPE_CODE_ARRAY && TYPE_CODE (type) !=3D TYPE_CODE_PTR) - error( _("Cannot subscript requested type.")); + error (_("Cannot subscript requested type.")); else res_val =3D value_subscript (tmp, value_as_long (idx)); }