Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFC] One more ARI related fix
Date: Fri, 18 Mar 2011 15:18:00 -0000	[thread overview]
Message-ID: <001801cbe57b$a3ad41d0$eb07c570$@muller@ics-cnrs.unistra.fr> (raw)

  The wrong formatting of error function call 
in valpy_getitem function leads to a false
ARI warning.
  The patch could probably gt in as obvious
as it just is a formatting patch,
but my question is if I should mention
the reason that made me submit that patch?

  This patch, together with a separate commit
to gdb_ari.sh, in order not to require _() around simple "%s" 
string should remove all markup ARI warnings.

  Is the ChangeLog OK as is,
or should I mention the ARI rule?

Pierre



2011-03-18  Pierre Muller  <muller@ics.u-strasbg.fr>

	* python/py-value.c (valpy_getitem): Fix formatting of error
function
	call.

Index: python/py-value.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-value.c,v
retrieving revision 1.23
diff -u -p -r1.23 py-value.c
--- python/py-value.c	28 Feb 2011 19:38:34 -0000	1.23
+++ python/py-value.c	18 Mar 2011 14:40:15 -0000
@@ -479,7 +479,7 @@ valpy_getitem (PyObject *self, PyObject 
 	      type = check_typedef (value_type (tmp));
 	      if (TYPE_CODE (type) != TYPE_CODE_ARRAY
 		  && TYPE_CODE (type) != TYPE_CODE_PTR)
-		  error( _("Cannot subscript requested type."));
+		  error(_("Cannot subscript requested type."));
 	      else
 		res_val = value_subscript (tmp, value_as_long (idx));
 	    }


             reply	other threads:[~2011-03-18 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 15:18 Pierre Muller [this message]
2011-03-18 16:30 ` Joel Brobecker
2011-03-18 17:02   ` Pierre Muller
     [not found] <001801cbe57b$a3ad41d0$eb07c570$%muller@ics-cnrs.unistra.fr>
2011-03-18 16:06 ` Eli Zaretskii
2011-03-18 16:11   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001801cbe57b$a3ad41d0$eb07c570$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox