From: Eli Zaretskii <eliz@gnu.org>
To: "Abid, Hafiz" <hafiz_abid@mentor.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org,
stan@codesourcery.com, yao@codesourcery.com
Subject: Re: [patch] Change trace buffer size(v5)
Date: Fri, 08 Mar 2013 14:09:00 -0000 [thread overview]
Message-ID: <83fw06yof8.fsf@gnu.org> (raw)
In-Reply-To: <1362742183.28338.0@abidh-ubunto1104>
> Date: Fri, 8 Mar 2013 11:29:43 +0000
> From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> CC: <gdb-patches@sourceware.org>, <stan@codesourcery.com>,
> <yao@codesourcery.com>, <eliz@gnu.org>
>
> gdb/
> * NEWS: Mention set and show trace-buffer-size commands.
> Mention new packet.
> * target.h (struct target_ops): New method
> to_set_trace_buffer_size.
> (target_set_trace_buffer_size): New macro.
> * target.c (update_current_target): Set up new method.
> * tracepoint.c (trace_buffer_size): New global.
> (start_tracing): Send it to the target.
> (set_trace_buffer_size): New function.
> (_initialize_tracepoint): Add new setshow for trace-buffer-size.
> * remote.c (remote_set_trace_buffer_size): New function.
> (_initialize_remote): Use it.
> (QTBuffer:size) New remote command.
> (PACKET_QTBuffer_size): New enum.
> (remote_protocol_features): Add an entry for
> PACKET_QTBuffer_size.
>
> gdb/gdbserver/
> * tracepoint.c (trace_buffer_size): New global.
> (DEFAULT_TRACE_BUFFER_SIZE): New define.
> (init_trace_buffer): Change to one-argument function. Allocate
> trace buffer memory.
> (handle_tracepoint_general_set): Call cmd_bigqtbuffer_size to
> handle QTBuffer:size packet.
> (cmd_bigqtbuffer_size): New function.
> (initialize_tracepoint): Call init_trace_buffer with
> DEFAULT_TRACE_BUFFER_SIZE.
> * server.c (handle_query): Add QTBuffer:size in the
> supported packets.
>
> gdb/doc/
> * gdb.texinfo (Starting and Stopping Trace Experiments):
> Document
> trace-buffer-size set and show commands.
> (Tracepoint Packets): Document QTBuffer:size.
> (General Query Packets): Document QTBuffer:size.
>
> gdb/testsuite/
> * gdb.trace/trace-buffer-size.exp: New file.
> * gdb.trace/trace-buffer-size.c: New file.
I already approved the documentation parts of this, didn't I?
next prev parent reply other threads:[~2013-03-08 14:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:13 [patch] Change trace buffer size Abid, Hafiz
2013-02-18 20:00 ` Eli Zaretskii
2013-02-19 2:53 ` Yao Qi
2013-02-27 16:55 ` Pedro Alves
2013-02-28 0:52 ` Yao Qi
2013-02-27 16:39 ` Pedro Alves
2013-03-01 17:07 ` [patch] Change trace buffer size(v2) Abid, Hafiz
2013-03-01 18:13 ` zinteger setshow commands broken Pedro Alves
2013-03-04 10:10 ` Abid, Hafiz
2013-03-04 10:16 ` Yao Qi
2013-03-04 10:28 ` Pedro Alves
2013-03-01 20:02 ` [patch] Change trace buffer size(v2) Pedro Alves
2013-03-04 19:03 ` [patch] Change trace buffer size(v3) Abid, Hafiz
2013-03-04 20:43 ` Pedro Alves
2013-03-05 14:12 ` [patch] Change trace buffer size(v4) Abid, Hafiz
2013-03-05 20:13 ` Pedro Alves
2013-03-08 11:30 ` [patch] Change trace buffer size(v5) Abid, Hafiz
2013-03-08 14:09 ` Eli Zaretskii [this message]
2013-03-08 14:27 ` Abid, Hafiz
2013-03-08 14:28 ` Pedro Alves
2013-03-08 14:52 ` Yao Qi
2013-03-08 15:15 ` Abid, Hafiz
2013-03-08 15:27 ` Yao Qi
2013-05-02 17:31 ` Pedro Alves
2013-05-03 11:38 ` Abid, Hafiz
2013-05-03 14:05 ` Pedro Alves
2013-05-03 15:08 ` Abid, Hafiz
2013-05-03 15:26 ` Pedro Alves
2013-03-09 2:06 ` Joel Brobecker
2013-03-09 8:27 ` Eli Zaretskii
2013-03-09 10:20 ` Abid, Hafiz
2013-03-09 10:39 ` Abid, Hafiz
2013-03-09 11:11 ` Eli Zaretskii
2013-03-09 11:07 ` Eli Zaretskii
2013-03-11 18:33 ` Tom Tromey
2013-03-11 19:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fw06yof8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=hafiz_abid@mentor.com \
--cc=palves@redhat.com \
--cc=stan@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox