From: "Abid, Hafiz" <hafiz_abid@mentor.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>,
<stan@codesourcery.com>, <eliz@gnu.org>
Subject: Re: [patch] Change trace buffer size(v5)
Date: Fri, 08 Mar 2013 15:15:00 -0000 [thread overview]
Message-ID: <1362755693.30327.1@abidh-ubunto1104> (raw)
In-Reply-To: <5139FACD.4020203@codesourcery.com> (from yao@codesourcery.com on Fri Mar 8 14:50:53 2013)
Hi Yao,
Sorry, I had already applied the patch before I saw your email.
> Minor suggestion, if they can fit in one line, better to write them
> in one line. The first backslash is not necessary. Here and
> somewhere else. We can write them in two lines:
>
> gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \
> "set trace buffer size 1"
I will keep this in mind for future work.
>> Document
>> trace-buffer-size set and show commands.
>
> The indentation looks odd here.
>
>> + set_trace_buffer_size, NULL,
>> + &setlist, &showlist);
>> +
>
> Indentation looks odd to me.
If you can let me know which portion is wrong then it will help me.
Thanks,
Abid
next prev parent reply other threads:[~2013-03-08 15:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:13 [patch] Change trace buffer size Abid, Hafiz
2013-02-18 20:00 ` Eli Zaretskii
2013-02-19 2:53 ` Yao Qi
2013-02-27 16:55 ` Pedro Alves
2013-02-28 0:52 ` Yao Qi
2013-02-27 16:39 ` Pedro Alves
2013-03-01 17:07 ` [patch] Change trace buffer size(v2) Abid, Hafiz
2013-03-01 18:13 ` zinteger setshow commands broken Pedro Alves
2013-03-04 10:10 ` Abid, Hafiz
2013-03-04 10:16 ` Yao Qi
2013-03-04 10:28 ` Pedro Alves
2013-03-01 20:02 ` [patch] Change trace buffer size(v2) Pedro Alves
2013-03-04 19:03 ` [patch] Change trace buffer size(v3) Abid, Hafiz
2013-03-04 20:43 ` Pedro Alves
2013-03-05 14:12 ` [patch] Change trace buffer size(v4) Abid, Hafiz
2013-03-05 20:13 ` Pedro Alves
2013-03-08 11:30 ` [patch] Change trace buffer size(v5) Abid, Hafiz
2013-03-08 14:09 ` Eli Zaretskii
2013-03-08 14:27 ` Abid, Hafiz
2013-03-08 14:28 ` Pedro Alves
2013-03-08 14:52 ` Yao Qi
2013-03-08 15:15 ` Abid, Hafiz [this message]
2013-03-08 15:27 ` Yao Qi
2013-05-02 17:31 ` Pedro Alves
2013-05-03 11:38 ` Abid, Hafiz
2013-05-03 14:05 ` Pedro Alves
2013-05-03 15:08 ` Abid, Hafiz
2013-05-03 15:26 ` Pedro Alves
2013-03-09 2:06 ` Joel Brobecker
2013-03-09 8:27 ` Eli Zaretskii
2013-03-09 10:20 ` Abid, Hafiz
2013-03-09 10:39 ` Abid, Hafiz
2013-03-09 11:11 ` Eli Zaretskii
2013-03-09 11:07 ` Eli Zaretskii
2013-03-11 18:33 ` Tom Tromey
2013-03-11 19:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362755693.30327.1@abidh-ubunto1104 \
--to=hafiz_abid@mentor.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=stan@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox