Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: "Abid, Hafiz" <hafiz_abid@mentor.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>,
	<stan@codesourcery.com>, <eliz@gnu.org>
Subject: Re: [patch] Change trace buffer size(v5)
Date: Fri, 08 Mar 2013 15:27:00 -0000	[thread overview]
Message-ID: <513A02FB.1030203@codesourcery.com> (raw)
In-Reply-To: <1362755693.30327.1@abidh-ubunto1104>

On 03/08/2013 11:14 PM, Abid, Hafiz wrote:
> Sorry, I had already applied the patch before I saw your email.
> 

Never mind.

>>> >>Document
>>> >>	trace-buffer-size set and show commands.
>> >
>> >The indentation looks odd here.
>> >

The doc/ChangeLog is correct.  Looks it was caused by copying changelog
entry into the mail.

>>> >>+			    set_trace_buffer_size, NULL,
>>> >>+			    &setlist, &showlist);
>>> >>+
>> >
>> >Indentation looks odd to me.
> If you can let me know which portion is wrong then it will help me.

The patch below fixes the problem I mentioned.  Committed as it is obvious.
-- 
Yao (齐尧)

gdb/
2013-03-08  Yao Qi  <yao@codesourcery.com>

	* tracepoint.c (_initialize_tracepoint): Indent the code.

Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.284
diff -u -r1.284 tracepoint.c
--- tracepoint.c	8 Mar 2013 15:06:35 -0000	1.284
+++ tracepoint.c	8 Mar 2013 15:18:43 -0000
@@ -5423,14 +5423,14 @@
 			   &showlist);
 
   add_setshow_zuinteger_unlimited_cmd ("trace-buffer-size", no_class,
-			    &trace_buffer_size, _("\
+				       &trace_buffer_size, _("\
 Set requested size of trace buffer."), _("\
 Show requested size of trace buffer."), _("\
 Use this to choose a size for the trace buffer.  Some targets\n\
 may have fixed or limited buffer sizes.  A value of -1 disables\n\
 any attempt to set the buffer size and lets the target choose."),
-			    set_trace_buffer_size, NULL,
-			    &setlist, &showlist);
+				       set_trace_buffer_size, NULL,
+				       &setlist, &showlist);
 
   add_setshow_string_cmd ("trace-user", class_trace,
 			  &trace_user, _("\


  reply	other threads:[~2013-03-08 15:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 18:13 [patch] Change trace buffer size Abid, Hafiz
2013-02-18 20:00 ` Eli Zaretskii
2013-02-19  2:53 ` Yao Qi
2013-02-27 16:55   ` Pedro Alves
2013-02-28  0:52     ` Yao Qi
2013-02-27 16:39 ` Pedro Alves
2013-03-01 17:07   ` [patch] Change trace buffer size(v2) Abid, Hafiz
2013-03-01 18:13     ` zinteger setshow commands broken Pedro Alves
2013-03-04 10:10       ` Abid, Hafiz
2013-03-04 10:16         ` Yao Qi
2013-03-04 10:28         ` Pedro Alves
2013-03-01 20:02     ` [patch] Change trace buffer size(v2) Pedro Alves
2013-03-04 19:03       ` [patch] Change trace buffer size(v3) Abid, Hafiz
2013-03-04 20:43         ` Pedro Alves
2013-03-05 14:12           ` [patch] Change trace buffer size(v4) Abid, Hafiz
2013-03-05 20:13             ` Pedro Alves
2013-03-08 11:30               ` [patch] Change trace buffer size(v5) Abid, Hafiz
2013-03-08 14:09                 ` Eli Zaretskii
2013-03-08 14:27                   ` Abid, Hafiz
2013-03-08 14:28                 ` Pedro Alves
2013-03-08 14:52                 ` Yao Qi
2013-03-08 15:15                   ` Abid, Hafiz
2013-03-08 15:27                     ` Yao Qi [this message]
2013-05-02 17:31                     ` Pedro Alves
2013-05-03 11:38                       ` Abid, Hafiz
2013-05-03 14:05                         ` Pedro Alves
2013-05-03 15:08                           ` Abid, Hafiz
2013-05-03 15:26                             ` Pedro Alves
2013-03-09  2:06                 ` Joel Brobecker
2013-03-09  8:27                   ` Eli Zaretskii
2013-03-09 10:20                     ` Abid, Hafiz
2013-03-09 10:39                       ` Abid, Hafiz
2013-03-09 11:11                         ` Eli Zaretskii
2013-03-09 11:07                       ` Eli Zaretskii
2013-03-11 18:33                         ` Tom Tromey
2013-03-11 19:44                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513A02FB.1030203@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hafiz_abid@mentor.com \
    --cc=palves@redhat.com \
    --cc=stan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox