From: Eli Zaretskii <eliz@gnu.org>
To: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [patch] Change trace buffer size(v5)
Date: Sat, 09 Mar 2013 11:07:00 -0000 [thread overview]
Message-ID: <83ehfoygpr.fsf@gnu.org> (raw)
In-Reply-To: <EB3B29AD43CA924DA27099BC8519237696D0B188@EU-MBX-03.mgc.mentorg.com>
> From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Sat, 9 Mar 2013 10:20:12 +0000
>
> I am committing the patch below to fix the build. I think it counts as obvious. Please let me know if there is any problem. Sorry for the inconvenience.
>
> Thanks,
> Abid
>
> 2012-03-09 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> gdb/doc/
> * gdb.texinfo (QTBuffer:size): Add cindex and anchor.
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index f0caef1..ba03fca 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -38479,6 +38479,8 @@ This packet directs the target to use a circular trace buffer if
> @var{value} is 1, or a linear buffer if the value is 0.
>
> @item QTBuffer:size:@var{size}
> +@anchor{QTBuffer:size}
> +@cindex @samp{QTBuffer:size} packet
Sorry, but this isn't right. You cannot have colons in @anchor or in
@cindex entries, because that will confuse Info readers when they try
to deduce the referenced spot. (This is explained in the Texinfo
manual, in the nodes "Node Line Requirements", "@anchor", and
"Indexing Commands".)
Fixed thusly:
2013-03-09 Eli Zaretskii <eliz@gnu.org>
* gdb.texinfo (General Query Packets, Tracepoint Packets): Don't
use colons in @anchor and @cindex entries.
Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.1056
retrieving revision 1.1057
diff -u -r1.1056 -r1.1057
--- gdb/doc/gdb.texinfo 9 Mar 2013 10:21:42 -0000 1.1056
+++ gdb/doc/gdb.texinfo 9 Mar 2013 11:01:00 -0000 1.1057
@@ -37552,7 +37552,7 @@
to be enabled and disabled while a trace experiment is running.
@item QTBuffer:size
-The remote stub supports the @samp{QTBuffer:size} (@pxref{QTBuffer:size})
+The remote stub supports the @samp{QTBuffer:size} (@pxref{QTBuffer-size})
packet that allows to change the size of the trace buffer.
@item tracenz
@@ -38479,8 +38479,8 @@
@var{value} is 1, or a linear buffer if the value is 0.
@item QTBuffer:size:@var{size}
-@anchor{QTBuffer:size}
-@cindex @samp{QTBuffer:size} packet
+@anchor{QTBuffer-size}
+@cindex @samp{QTBuffer size} packet
This packet directs the target to make the trace buffer be of size
@var{size} if possible. A value of @code{-1} tells the target to
use whatever size it prefers.
next prev parent reply other threads:[~2013-03-09 11:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:13 [patch] Change trace buffer size Abid, Hafiz
2013-02-18 20:00 ` Eli Zaretskii
2013-02-19 2:53 ` Yao Qi
2013-02-27 16:55 ` Pedro Alves
2013-02-28 0:52 ` Yao Qi
2013-02-27 16:39 ` Pedro Alves
2013-03-01 17:07 ` [patch] Change trace buffer size(v2) Abid, Hafiz
2013-03-01 18:13 ` zinteger setshow commands broken Pedro Alves
2013-03-04 10:10 ` Abid, Hafiz
2013-03-04 10:16 ` Yao Qi
2013-03-04 10:28 ` Pedro Alves
2013-03-01 20:02 ` [patch] Change trace buffer size(v2) Pedro Alves
2013-03-04 19:03 ` [patch] Change trace buffer size(v3) Abid, Hafiz
2013-03-04 20:43 ` Pedro Alves
2013-03-05 14:12 ` [patch] Change trace buffer size(v4) Abid, Hafiz
2013-03-05 20:13 ` Pedro Alves
2013-03-08 11:30 ` [patch] Change trace buffer size(v5) Abid, Hafiz
2013-03-08 14:09 ` Eli Zaretskii
2013-03-08 14:27 ` Abid, Hafiz
2013-03-08 14:28 ` Pedro Alves
2013-03-08 14:52 ` Yao Qi
2013-03-08 15:15 ` Abid, Hafiz
2013-03-08 15:27 ` Yao Qi
2013-05-02 17:31 ` Pedro Alves
2013-05-03 11:38 ` Abid, Hafiz
2013-05-03 14:05 ` Pedro Alves
2013-05-03 15:08 ` Abid, Hafiz
2013-05-03 15:26 ` Pedro Alves
2013-03-09 2:06 ` Joel Brobecker
2013-03-09 8:27 ` Eli Zaretskii
2013-03-09 10:20 ` Abid, Hafiz
2013-03-09 10:39 ` Abid, Hafiz
2013-03-09 11:11 ` Eli Zaretskii
2013-03-09 11:07 ` Eli Zaretskii [this message]
2013-03-11 18:33 ` Tom Tromey
2013-03-11 19:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehfoygpr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=Hafiz_Abid@mentor.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox