From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "Abid, Hafiz" <hafiz_abid@mentor.com>,
gdb-patches@sourceware.org, stan@codesourcery.com
Subject: Re: [patch] Change trace buffer size
Date: Wed, 27 Feb 2013 16:55:00 -0000 [thread overview]
Message-ID: <512E3A63.9040209@redhat.com> (raw)
In-Reply-To: <5122E8C9.2070205@codesourcery.com>
On 02/19/2013 02:51 AM, Yao Qi wrote:
>>
>
> We may mention the new remote packet in NEWS.
Indeed. s/may/should/.
>>
>> @@ -912,6 +913,9 @@ update_current_target (void)
>> de_fault (to_set_circular_trace_buffer,
>> (void (*) (int))
>> target_ignore);
>> + de_fault (to_set_trace_buffer_size,
>> + (void (*) (LONGEST))
>> + target_ignore);
>
> I am wondering 'tcomplain' may be better than 'target_ignore'.
I think it's better to have the command behave the
same as the other related "set circular-trace-buffer"
set disconnected-tracing. We've discussed this behavior in
the context of the patch that adds one of these other
commands (or both?).
Do you see a reason this command should behave different?
tcomplain would trigger if you used the "set ..." command
before being connected to any target (or after disconnecting).
--
Pedro Alves
next prev parent reply other threads:[~2013-02-27 16:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:13 Abid, Hafiz
2013-02-18 20:00 ` Eli Zaretskii
2013-02-19 2:53 ` Yao Qi
2013-02-27 16:55 ` Pedro Alves [this message]
2013-02-28 0:52 ` Yao Qi
2013-02-27 16:39 ` Pedro Alves
2013-03-01 17:07 ` [patch] Change trace buffer size(v2) Abid, Hafiz
2013-03-01 18:13 ` zinteger setshow commands broken Pedro Alves
2013-03-04 10:10 ` Abid, Hafiz
2013-03-04 10:16 ` Yao Qi
2013-03-04 10:28 ` Pedro Alves
2013-03-01 20:02 ` [patch] Change trace buffer size(v2) Pedro Alves
2013-03-04 19:03 ` [patch] Change trace buffer size(v3) Abid, Hafiz
2013-03-04 20:43 ` Pedro Alves
2013-03-05 14:12 ` [patch] Change trace buffer size(v4) Abid, Hafiz
2013-03-05 20:13 ` Pedro Alves
2013-03-08 11:30 ` [patch] Change trace buffer size(v5) Abid, Hafiz
2013-03-08 14:09 ` Eli Zaretskii
2013-03-08 14:27 ` Abid, Hafiz
2013-03-08 14:28 ` Pedro Alves
2013-03-08 14:52 ` Yao Qi
2013-03-08 15:15 ` Abid, Hafiz
2013-03-08 15:27 ` Yao Qi
2013-05-02 17:31 ` Pedro Alves
2013-05-03 11:38 ` Abid, Hafiz
2013-05-03 14:05 ` Pedro Alves
2013-05-03 15:08 ` Abid, Hafiz
2013-05-03 15:26 ` Pedro Alves
2013-03-09 2:06 ` Joel Brobecker
2013-03-09 8:27 ` Eli Zaretskii
2013-03-09 10:20 ` Abid, Hafiz
2013-03-09 10:39 ` Abid, Hafiz
2013-03-09 11:11 ` Eli Zaretskii
2013-03-09 11:07 ` Eli Zaretskii
2013-03-11 18:33 ` Tom Tromey
2013-03-11 19:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E3A63.9040209@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hafiz_abid@mentor.com \
--cc=stan@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox