Re: [patch] Change trace buffer size(v5)

[Yao Qi <yao@codesourcery.com>]

Hi Abid,

On 03/08/2013 07:29 PM, Abid, Hafiz wrote:
> 	gdb/doc/
> 	* gdb.texinfo (Starting and Stopping Trace Experiments):
> Document
> 	trace-buffer-size set and show commands.

The indentation looks odd here.

> +
> +# Change buffer size to 'BUFFER_SIZE'.
> +gdb_test_no_output \
> +  "set trace-buffer-size $BUFFER_SIZE" \
> +  "set trace buffer size 1"

Minor suggestion, if they can fit in one line, better to write them in 
one line.  The first backslash is not necessary.  Here and somewhere 
else.  We can write them in two lines:

gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \
   "set trace buffer size 1"

> +  add_setshow_zuinteger_unlimited_cmd ("trace-buffer-size", no_class,
> +			    &trace_buffer_size, _("\
> +Set requested size of trace buffer."), _("\
> +Show requested size of trace buffer."), _("\
> +Use this to choose a size for the trace buffer.  Some targets\n\
> +may have fixed or limited buffer sizes.  A value of -1 disables\n\
> +any attempt to set the buffer size and lets the target choose."),
> +			    set_trace_buffer_size, NULL,
> +			    &setlist, &showlist);
> +

Indentation looks odd to me.

-- 
Yao (齐尧)