From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1186 invoked by alias); 8 Mar 2013 14:52:51 -0000 Received: (qmail 1175 invoked by uid 22791); 8 Mar 2013 14:52:49 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 14:52:41 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UDyf1-0003pR-Tu from Yao_Qi@mentor.com ; Fri, 08 Mar 2013 06:52:39 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 8 Mar 2013 06:52:39 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Fri, 8 Mar 2013 06:52:39 -0800 Message-ID: <5139FACD.4020203@codesourcery.com> Date: Fri, 08 Mar 2013 14:52:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Abid, Hafiz" CC: Pedro Alves , , , Subject: Re: [patch] Change trace buffer size(v5) References: <1362742183.28338.0@abidh-ubunto1104> In-Reply-To: <1362742183.28338.0@abidh-ubunto1104> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00372.txt.bz2 Hi Abid, On 03/08/2013 07:29 PM, Abid, Hafiz wrote: > gdb/doc/ > * gdb.texinfo (Starting and Stopping Trace Experiments): > Document > trace-buffer-size set and show commands. The indentation looks odd here. > + > +# Change buffer size to 'BUFFER_SIZE'. > +gdb_test_no_output \ > + "set trace-buffer-size $BUFFER_SIZE" \ > + "set trace buffer size 1" Minor suggestion, if they can fit in one line, better to write them in one line. The first backslash is not necessary. Here and somewhere else. We can write them in two lines: gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \ "set trace buffer size 1" > + add_setshow_zuinteger_unlimited_cmd ("trace-buffer-size", no_class, > + &trace_buffer_size, _("\ > +Set requested size of trace buffer."), _("\ > +Show requested size of trace buffer."), _("\ > +Use this to choose a size for the trace buffer. Some targets\n\ > +may have fixed or limited buffer sizes. A value of -1 disables\n\ > +any attempt to set the buffer size and lets the target choose."), > + set_trace_buffer_size, NULL, > + &setlist, &showlist); > + Indentation looks odd to me. -- Yao (齐尧)