From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16855 invoked by alias); 8 Mar 2013 15:27:39 -0000 Received: (qmail 16833 invoked by uid 22791); 8 Mar 2013 15:27:36 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 15:27:04 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UDzCJ-0006ww-8U from Yao_Qi@mentor.com ; Fri, 08 Mar 2013 07:27:03 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 8 Mar 2013 07:27:03 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Fri, 8 Mar 2013 07:27:01 -0800 Message-ID: <513A02FB.1030203@codesourcery.com> Date: Fri, 08 Mar 2013 15:27:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Abid, Hafiz" CC: Pedro Alves , , , Subject: Re: [patch] Change trace buffer size(v5) References: <1362755693.30327.1@abidh-ubunto1104> In-Reply-To: <1362755693.30327.1@abidh-ubunto1104> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00378.txt.bz2 On 03/08/2013 11:14 PM, Abid, Hafiz wrote: > Sorry, I had already applied the patch before I saw your email. > Never mind. >>> >>Document >>> >> trace-buffer-size set and show commands. >> > >> >The indentation looks odd here. >> > The doc/ChangeLog is correct. Looks it was caused by copying changelog entry into the mail. >>> >>+ set_trace_buffer_size, NULL, >>> >>+ &setlist, &showlist); >>> >>+ >> > >> >Indentation looks odd to me. > If you can let me know which portion is wrong then it will help me. The patch below fixes the problem I mentioned. Committed as it is obvious. -- Yao (齐尧) gdb/ 2013-03-08 Yao Qi * tracepoint.c (_initialize_tracepoint): Indent the code. Index: tracepoint.c =================================================================== RCS file: /cvs/src/src/gdb/tracepoint.c,v retrieving revision 1.284 diff -u -r1.284 tracepoint.c --- tracepoint.c 8 Mar 2013 15:06:35 -0000 1.284 +++ tracepoint.c 8 Mar 2013 15:18:43 -0000 @@ -5423,14 +5423,14 @@ &showlist); add_setshow_zuinteger_unlimited_cmd ("trace-buffer-size", no_class, - &trace_buffer_size, _("\ + &trace_buffer_size, _("\ Set requested size of trace buffer."), _("\ Show requested size of trace buffer."), _("\ Use this to choose a size for the trace buffer. Some targets\n\ may have fixed or limited buffer sizes. A value of -1 disables\n\ any attempt to set the buffer size and lets the target choose."), - set_trace_buffer_size, NULL, - &setlist, &showlist); + set_trace_buffer_size, NULL, + &setlist, &showlist); add_setshow_string_cmd ("trace-user", class_trace, &trace_user, _("\