From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99300-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11779 invoked by alias); 8 Mar 2013 15:15:09 -0000
Received: (qmail 11759 invoked by uid 22791); 8 Mar 2013 15:15:07 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 15:14:59 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1UDz0c-00060n-5u from Hafiz_Abid@mentor.com ; Fri, 08 Mar 2013 07:14:58 -0800
Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 8 Mar 2013 07:14:57 -0800
Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.1.289.1; Fri, 8 Mar 2013 15:14:55 +0000
Date: Fri, 08 Mar 2013 15:15:00 -0000
From: "Abid, Hafiz" <hafiz_abid@mentor.com>
Subject: Re: [patch] Change trace buffer size(v5)
To: Yao Qi <yao@codesourcery.com>
CC: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>,	<stan@codesourcery.com>, <eliz@gnu.org>
In-Reply-To: <5139FACD.4020203@codesourcery.com> (from yao@codesourcery.com	on Fri Mar  8 14:50:53 2013)
Message-ID: <1362755693.30327.1@abidh-ubunto1104>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00376.txt.bz2

Hi Yao,
Sorry, I had already applied the patch before I saw your email.

> Minor suggestion, if they can fit in one line, better to write them=20=20
> in one line.  The first backslash is not necessary.  Here and=20=20
> somewhere else.  We can write them in two lines:
>=20
> gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \
>   "set trace buffer size 1"
I will keep this in mind for future work.

>> Document
>> 	trace-buffer-size set and show commands.
>=20
> The indentation looks odd here.
>=20
>> +			    set_trace_buffer_size, NULL,
>> +			    &setlist, &showlist);
>> +
>=20
> Indentation looks odd to me.

If you can let me know which portion is wrong then it will help me.

Thanks,
Abid