From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30450 invoked by alias); 8 Mar 2013 14:09:07 -0000 Received: (qmail 30421 invoked by uid 22791); 8 Mar 2013 14:09:06 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL,TW_QT X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 14:08:25 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MJC00I00HV0UL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 08 Mar 2013 16:08:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJC00IB4HXZP470@a-mtaout20.012.net.il>; Fri, 08 Mar 2013 16:08:23 +0200 (IST) Date: Fri, 08 Mar 2013 14:09:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Change trace buffer size(v5) In-reply-to: <1362742183.28338.0@abidh-ubunto1104> To: "Abid, Hafiz" Cc: palves@redhat.com, gdb-patches@sourceware.org, stan@codesourcery.com, yao@codesourcery.com Reply-to: Eli Zaretskii Message-id: <83fw06yof8.fsf@gnu.org> References: <1362742183.28338.0@abidh-ubunto1104> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00366.txt.bz2 > Date: Fri, 8 Mar 2013 11:29:43 +0000 > From: "Abid, Hafiz" > CC: , , > , > > gdb/ > * NEWS: Mention set and show trace-buffer-size commands. > Mention new packet. > * target.h (struct target_ops): New method > to_set_trace_buffer_size. > (target_set_trace_buffer_size): New macro. > * target.c (update_current_target): Set up new method. > * tracepoint.c (trace_buffer_size): New global. > (start_tracing): Send it to the target. > (set_trace_buffer_size): New function. > (_initialize_tracepoint): Add new setshow for trace-buffer-size. > * remote.c (remote_set_trace_buffer_size): New function. > (_initialize_remote): Use it. > (QTBuffer:size) New remote command. > (PACKET_QTBuffer_size): New enum. > (remote_protocol_features): Add an entry for > PACKET_QTBuffer_size. > > gdb/gdbserver/ > * tracepoint.c (trace_buffer_size): New global. > (DEFAULT_TRACE_BUFFER_SIZE): New define. > (init_trace_buffer): Change to one-argument function. Allocate > trace buffer memory. > (handle_tracepoint_general_set): Call cmd_bigqtbuffer_size to > handle QTBuffer:size packet. > (cmd_bigqtbuffer_size): New function. > (initialize_tracepoint): Call init_trace_buffer with > DEFAULT_TRACE_BUFFER_SIZE. > * server.c (handle_query): Add QTBuffer:size in the > supported packets. > > gdb/doc/ > * gdb.texinfo (Starting and Stopping Trace Experiments): > Document > trace-buffer-size set and show commands. > (Tracepoint Packets): Document QTBuffer:size. > (General Query Packets): Document QTBuffer:size. > > gdb/testsuite/ > * gdb.trace/trace-buffer-size.exp: New file. > * gdb.trace/trace-buffer-size.c: New file. I already approved the documentation parts of this, didn't I?