[RFA record/replay] displaced stepping and record/replay

[RFA record/replay] displaced stepping and record/replay

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hui --

I think I may have stumbled on the answer to this whole problem!
One line change -- just don't allow displaced stepping when in
record *or* replay mode.

Michael


[-- Attachment #2: displaced.txt --]
[-- Type: text/plain, Size: 686 bytes --]

2008-10-05  Michael Snyder  <msnyder@vmware.com>

	* infrun.c (use_displaced_stepping): Disallow displaced
	stepping if using record/replay target.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.300.2.8
diff -u -p -r1.300.2.8 infrun.c
--- infrun.c	5 Oct 2008 20:00:36 -0000	1.300.2.8
+++ infrun.c	5 Oct 2008 21:23:48 -0000
@@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch *
 {
   return (can_use_displaced_stepping
 	  && gdbarch_displaced_step_copy_insn_p (gdbarch)
-	  && !RECORD_IS_REPLAY);
+	  && !RECORD_IS_USED);
 }
 
 /* Clean out any stray displaced stepping state.  */

Re: [RFA record/replay] displaced stepping and record/replay

[teawater]

Looks good. Please check it in.

Thanks,
Hui

On Mon, Oct 6, 2008 at 05:27, Michael Snyder <msnyder@vmware.com> wrote:
> Hui --
>
> I think I may have stumbled on the answer to this whole problem!
> One line change -- just don't allow displaced stepping when in
> record *or* replay mode.
>
> Michael
>
>
> 2008-10-05  Michael Snyder  <msnyder@vmware.com>
>
>        * infrun.c (use_displaced_stepping): Disallow displaced
>        stepping if using record/replay target.
>
> Index: infrun.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/infrun.c,v
> retrieving revision 1.300.2.8
> diff -u -p -r1.300.2.8 infrun.c
> --- infrun.c    5 Oct 2008 20:00:36 -0000       1.300.2.8
> +++ infrun.c    5 Oct 2008 21:23:48 -0000
> @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch *
>  {
>   return (can_use_displaced_stepping
>          && gdbarch_displaced_step_copy_insn_p (gdbarch)
> -         && !RECORD_IS_REPLAY);
> +         && !RECORD_IS_USED);
>  }
>
>  /* Clean out any stray displaced stepping state.  */
>
>

Re: [RFA record/replay] displaced stepping and record/replay

[Michael Snyder]

Committed.

teawater wrote:
> Looks good. Please check it in.
> 
> Thanks,
> Hui
> 
> On Mon, Oct 6, 2008 at 05:27, Michael Snyder <msnyder@vmware.com> wrote:
>> Hui --
>>
>> I think I may have stumbled on the answer to this whole problem!
>> One line change -- just don't allow displaced stepping when in
>> record *or* replay mode.
>>
>> Michael
>>
>>
>> 2008-10-05  Michael Snyder  <msnyder@vmware.com>
>>
>>        * infrun.c (use_displaced_stepping): Disallow displaced
>>        stepping if using record/replay target.
>>
>> Index: infrun.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/infrun.c,v
>> retrieving revision 1.300.2.8
>> diff -u -p -r1.300.2.8 infrun.c
>> --- infrun.c    5 Oct 2008 20:00:36 -0000       1.300.2.8
>> +++ infrun.c    5 Oct 2008 21:23:48 -0000
>> @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch *
>>  {
>>   return (can_use_displaced_stepping
>>          && gdbarch_displaced_step_copy_insn_p (gdbarch)
>> -         && !RECORD_IS_REPLAY);
>> +         && !RECORD_IS_USED);
>>  }
>>
>>  /* Clean out any stray displaced stepping state.  */
>>
>>