From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32702 invoked by alias); 5 Oct 2008 21:29:43 -0000 Received: (qmail 32689 invoked by uid 22791); 5 Oct 2008 21:29:43 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Oct 2008 21:29:07 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 95F863E00B; Sun, 5 Oct 2008 14:29:06 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost4.vmware.com (Postfix) with ESMTP id 887B2C9A40; Sun, 5 Oct 2008 14:29:06 -0700 (PDT) Message-ID: <48E93140.1090408@vmware.com> Date: Sun, 05 Oct 2008 21:29:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , teawater Subject: [RFA record/replay] displaced stepping and record/replay Content-Type: multipart/mixed; boundary="------------060304060407030702040307" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00142.txt.bz2 This is a multi-part message in MIME format. --------------060304060407030702040307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 171 Hui -- I think I may have stumbled on the answer to this whole problem! One line change -- just don't allow displaced stepping when in record *or* replay mode. Michael --------------060304060407030702040307 Content-Type: text/plain; name="displaced.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="displaced.txt" Content-length: 686 2008-10-05 Michael Snyder * infrun.c (use_displaced_stepping): Disallow displaced stepping if using record/replay target. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.300.2.8 diff -u -p -r1.300.2.8 infrun.c --- infrun.c 5 Oct 2008 20:00:36 -0000 1.300.2.8 +++ infrun.c 5 Oct 2008 21:23:48 -0000 @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch * { return (can_use_displaced_stepping && gdbarch_displaced_step_copy_insn_p (gdbarch) - && !RECORD_IS_REPLAY); + && !RECORD_IS_USED); } /* Clean out any stray displaced stepping state. */ --------------060304060407030702040307--