From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31914 invoked by alias); 6 Oct 2008 17:25:03 -0000 Received: (qmail 31872 invoked by uid 22791); 6 Oct 2008 17:25:02 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 17:24:18 +0000 Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 00F5C67EA; Mon, 6 Oct 2008 10:24:17 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost5.vmware.com (Postfix) with ESMTP id DDBD7DC054; Mon, 6 Oct 2008 10:24:16 -0700 (PDT) Message-ID: <48EA4955.10802@vmware.com> Date: Mon, 06 Oct 2008 17:25:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: teawater CC: "gdb-patches@sourceware.org" Subject: Re: [RFA record/replay] displaced stepping and record/replay References: <48E93140.1090408@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00149.txt.bz2 Committed. teawater wrote: > Looks good. Please check it in. > > Thanks, > Hui > > On Mon, Oct 6, 2008 at 05:27, Michael Snyder wrote: >> Hui -- >> >> I think I may have stumbled on the answer to this whole problem! >> One line change -- just don't allow displaced stepping when in >> record *or* replay mode. >> >> Michael >> >> >> 2008-10-05 Michael Snyder >> >> * infrun.c (use_displaced_stepping): Disallow displaced >> stepping if using record/replay target. >> >> Index: infrun.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/infrun.c,v >> retrieving revision 1.300.2.8 >> diff -u -p -r1.300.2.8 infrun.c >> --- infrun.c 5 Oct 2008 20:00:36 -0000 1.300.2.8 >> +++ infrun.c 5 Oct 2008 21:23:48 -0000 >> @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch * >> { >> return (can_use_displaced_stepping >> && gdbarch_displaced_step_copy_insn_p (gdbarch) >> - && !RECORD_IS_REPLAY); >> + && !RECORD_IS_USED); >> } >> >> /* Clean out any stray displaced stepping state. */ >> >>