Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: teawater <teawater@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA record/replay] displaced stepping and record/replay
Date: Mon, 06 Oct 2008 17:25:00 -0000	[thread overview]
Message-ID: <48EA4955.10802@vmware.com> (raw)
In-Reply-To: <daef60380810060029t3ca14489q7485b08f9a47e5d1@mail.gmail.com>

Committed.

teawater wrote:
> Looks good. Please check it in.
> 
> Thanks,
> Hui
> 
> On Mon, Oct 6, 2008 at 05:27, Michael Snyder <msnyder@vmware.com> wrote:
>> Hui --
>>
>> I think I may have stumbled on the answer to this whole problem!
>> One line change -- just don't allow displaced stepping when in
>> record *or* replay mode.
>>
>> Michael
>>
>>
>> 2008-10-05  Michael Snyder  <msnyder@vmware.com>
>>
>>        * infrun.c (use_displaced_stepping): Disallow displaced
>>        stepping if using record/replay target.
>>
>> Index: infrun.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/infrun.c,v
>> retrieving revision 1.300.2.8
>> diff -u -p -r1.300.2.8 infrun.c
>> --- infrun.c    5 Oct 2008 20:00:36 -0000       1.300.2.8
>> +++ infrun.c    5 Oct 2008 21:23:48 -0000
>> @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch *
>>  {
>>   return (can_use_displaced_stepping
>>          && gdbarch_displaced_step_copy_insn_p (gdbarch)
>> -         && !RECORD_IS_REPLAY);
>> +         && !RECORD_IS_USED);
>>  }
>>
>>  /* Clean out any stray displaced stepping state.  */
>>
>>


      reply	other threads:[~2008-10-06 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-05 21:29 Michael Snyder
2008-10-06  7:30 ` teawater
2008-10-06 17:25   ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EA4955.10802@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox