From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31055 invoked by alias); 6 Oct 2008 07:30:33 -0000 Received: (qmail 31045 invoked by uid 22791); 6 Oct 2008 07:30:32 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.186) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 07:29:57 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1650235tib.12 for ; Mon, 06 Oct 2008 00:29:56 -0700 (PDT) Received: by 10.110.109.12 with SMTP id h12mr5756846tic.52.1223278196426; Mon, 06 Oct 2008 00:29:56 -0700 (PDT) Received: by 10.110.42.9 with HTTP; Mon, 6 Oct 2008 00:29:56 -0700 (PDT) Message-ID: Date: Mon, 06 Oct 2008 07:30:00 -0000 From: teawater To: "Michael Snyder" Subject: Re: [RFA record/replay] displaced stepping and record/replay Cc: "gdb-patches@sourceware.org" In-Reply-To: <48E93140.1090408@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48E93140.1090408@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00145.txt.bz2 Looks good. Please check it in. Thanks, Hui On Mon, Oct 6, 2008 at 05:27, Michael Snyder wrote: > Hui -- > > I think I may have stumbled on the answer to this whole problem! > One line change -- just don't allow displaced stepping when in > record *or* replay mode. > > Michael > > > 2008-10-05 Michael Snyder > > * infrun.c (use_displaced_stepping): Disallow displaced > stepping if using record/replay target. > > Index: infrun.c > =================================================================== > RCS file: /cvs/src/src/gdb/infrun.c,v > retrieving revision 1.300.2.8 > diff -u -p -r1.300.2.8 infrun.c > --- infrun.c 5 Oct 2008 20:00:36 -0000 1.300.2.8 > +++ infrun.c 5 Oct 2008 21:23:48 -0000 > @@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch * > { > return (can_use_displaced_stepping > && gdbarch_displaced_step_copy_insn_p (gdbarch) > - && !RECORD_IS_REPLAY); > + && !RECORD_IS_USED); > } > > /* Clean out any stray displaced stepping state. */ > >