Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: Jeff Johnston <jjohnstn@redhat.com>, Daniel Jacobowitz <drow@false.org>
Cc: Andrew Haley <aph@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Java Inferior Call Take 2
Date: Mon, 26 Jul 2004 19:49:00 -0000	[thread overview]
Message-ID: <4105604A.6030302@redhat.com> (raw)
In-Reply-To: <40EB1DDD.4070603@redhat.com>

Ping.

Jeff Johnston wrote:
> Daniel Jacobowitz wrote:
> 
>> On Wed, Jun 23, 2004 at 05:55:07PM -0400, Jeff Johnston wrote:
>>
>>> Daniel Jacobowitz wrote:
>>>
>>>> On Wed, Jun 23, 2004 at 12:05:59PM +0100, Andrew Haley wrote:
>>>>
>>>>
>>>>> This patch is now in mainline.  Is there anything else you need?
>>>>
>>>>
>>>>
>>>> Yes.  Two sets of questions left, one for Jeff and one [plus a little
>>>> bit] for you...
>>>>
>>>>
>>>> Jeff, one test still fails: calling addprint.  I think this is mostly a
>>>> GDB problem rather than GCC.  Before starting the program I see this:
>>>>
>>>
>>> Let me take a look at it.  It is not failing in my 
>>> all-patches-applied build. Perhaps in splitting the patches up, I 
>>> screwed up and missed something.
>>
>>
>>
>> Thanks.
>>
> 
> Ok, I figured out what piece I left out and have remade the patch.  I 
> can't remember where we are on this regarding the workaround for gcc 
> debug-info, but at least you will be able to run the test with the full 
> functionality now. Please let me know what is needed next as I want to 
> move this forward.
> 
> -- Jeff J.
> 
>>
>>>> - Should we suppress jvclass and <clinit> the way we do for C++
>>>>   artificial methods?
>>>>
>>>
>>> Perhaps remove <clinit>, but jvclass() is the constructor.  There 
>>> could be multiple constructors and as an end-user, I would want to 
>>> see the various prototypes.  I can't speak for what C++ does.
>>
>>
>>
>> In C++, the debug information marks whether a constructor was written
>> by the user (i.e. the type really contains a constructor) or by the
>> compiler (i.e. implicit).  I imagine Java's debug information has the
>> same thing.  For minimum confusion, we choose not to print the
>> artificial methods in C++ types; I think we should do the same for
>> Java.
>>
>> (This shouldn't affect breakpointing it for users who know the
>> constructor exists.)
>>
>>
>>
>>>> - Why did printing of the type change?  There's only one definition
>>>>   of jvclass in the debug info, and it's marked Java.
>>>>
>>>
>>> There are checks in the code based on current language.  The current 
>>> language does not start as java.  If you manually change it via set 
>>> language java, you will see the same results before and after.
>>
>>
>>
>> Bleeeeeeech.  Thanks for explaining; definitely not your problem, but
>> definitely a bug.  If we're printing a type we ought to be using the
>> type's language.
>>


  reply	other threads:[~2004-07-26 19:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-17 20:53 Jeff Johnston
2004-06-11 17:49 ` Jeff Johnston
2004-06-17  3:06 ` Daniel Jacobowitz
2004-06-17 20:52   ` Jeff Johnston
2004-06-19 23:59     ` Daniel Jacobowitz
2004-06-21 10:49       ` Andrew Haley
2004-06-21 15:17       ` Andrew Haley
2004-06-23 11:06         ` Andrew Haley
2004-06-23 13:47           ` Daniel Jacobowitz
2004-06-23 16:06             ` Andrew Haley
2004-06-23 16:08               ` Daniel Jacobowitz
2004-06-23 21:55             ` Jeff Johnston
2004-06-23 23:01               ` Daniel Jacobowitz
2004-06-24 17:57                 ` Tom Tromey
2004-07-06 21:47                 ` Jeff Johnston
2004-07-26 19:49                   ` Jeff Johnston [this message]
2004-07-26 19:51                     ` Daniel Jacobowitz
2004-08-02 10:17                       ` Andrew Haley
2004-08-02 15:17                         ` Andrew Haley
2004-08-02 20:20                           ` Daniel Jacobowitz
2004-08-03 18:45                             ` Andrew Haley
2004-08-16 13:08                               ` Andrew Haley
2004-08-16 13:18                                 ` Daniel Jacobowitz
2004-08-16 20:32                                   ` Daniel Jacobowitz
2004-08-16 20:35                   ` Daniel Jacobowitz
2004-08-24 18:53                     ` [RFA]: Java Inferior Call Take 3 Jeff Johnston
2004-08-24 19:05                       ` Michael Chastain
2004-08-24 19:28                         ` Jeff Johnston
2004-08-24 19:10                       ` Michael Chastain
2004-08-24 19:48                         ` Andrew Cagney
2004-09-01  4:51                       ` Jim Blandy
2004-09-09 23:41                         ` Jeff Johnston
2004-09-10 20:12                           ` Jim Blandy
2004-09-15 22:58                             ` Jeff Johnston
2004-09-20 18:23                               ` Jim Blandy
2004-09-20 20:19                                 ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4105604A.6030302@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=aph@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox