From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32553 invoked by alias); 26 Jul 2004 19:49:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32544 invoked from network); 26 Jul 2004 19:49:32 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 26 Jul 2004 19:49:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6QJnVe1010462 for ; Mon, 26 Jul 2004 15:49:31 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6QJnVa31216; Mon, 26 Jul 2004 15:49:31 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i6QJnVXP010899; Mon, 26 Jul 2004 15:49:31 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id E6683800484; Mon, 26 Jul 2004 15:49:30 -0400 (EDT) Message-ID: <4105604A.6030302@redhat.com> Date: Mon, 26 Jul 2004 19:49:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Jeff Johnston , Daniel Jacobowitz Cc: Andrew Haley , gdb-patches@sources.redhat.com Subject: Re: [RFA]: Java Inferior Call Take 2 References: <40A9264C.4060404@redhat.com> <20040617030603.GC23443@nevyn.them.org> <40D20494.2020608@redhat.com> <20040619235857.GA18759@nevyn.them.org> <16598.64375.217285.743094@cuddles.cambridge.redhat.com> <16601.25623.949217.642524@cuddles.cambridge.redhat.com> <20040623134742.GA24612@nevyn.them.org> <40D9FC3B.3030700@redhat.com> <20040623230138.GA6426@nevyn.them.org> <40EB1DDD.4070603@redhat.com> In-Reply-To: <40EB1DDD.4070603@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00375.txt.bz2 Ping. Jeff Johnston wrote: > Daniel Jacobowitz wrote: > >> On Wed, Jun 23, 2004 at 05:55:07PM -0400, Jeff Johnston wrote: >> >>> Daniel Jacobowitz wrote: >>> >>>> On Wed, Jun 23, 2004 at 12:05:59PM +0100, Andrew Haley wrote: >>>> >>>> >>>>> This patch is now in mainline. Is there anything else you need? >>>> >>>> >>>> >>>> Yes. Two sets of questions left, one for Jeff and one [plus a little >>>> bit] for you... >>>> >>>> >>>> Jeff, one test still fails: calling addprint. I think this is mostly a >>>> GDB problem rather than GCC. Before starting the program I see this: >>>> >>> >>> Let me take a look at it. It is not failing in my >>> all-patches-applied build. Perhaps in splitting the patches up, I >>> screwed up and missed something. >> >> >> >> Thanks. >> > > Ok, I figured out what piece I left out and have remade the patch. I > can't remember where we are on this regarding the workaround for gcc > debug-info, but at least you will be able to run the test with the full > functionality now. Please let me know what is needed next as I want to > move this forward. > > -- Jeff J. > >> >>>> - Should we suppress jvclass and the way we do for C++ >>>> artificial methods? >>>> >>> >>> Perhaps remove , but jvclass() is the constructor. There >>> could be multiple constructors and as an end-user, I would want to >>> see the various prototypes. I can't speak for what C++ does. >> >> >> >> In C++, the debug information marks whether a constructor was written >> by the user (i.e. the type really contains a constructor) or by the >> compiler (i.e. implicit). I imagine Java's debug information has the >> same thing. For minimum confusion, we choose not to print the >> artificial methods in C++ types; I think we should do the same for >> Java. >> >> (This shouldn't affect breakpointing it for users who know the >> constructor exists.) >> >> >> >>>> - Why did printing of the type change? There's only one definition >>>> of jvclass in the debug info, and it's marked Java. >>>> >>> >>> There are checks in the code based on current language. The current >>> language does not start as java. If you manually change it via set >>> language java, you will see the same results before and after. >> >> >> >> Bleeeeeeech. Thanks for explaining; definitely not your problem, but >> definitely a bug. If we're printing a type we ought to be using the >> type's language. >>