Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Jeff Johnston <jjohnstn@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Java Inferior Call Take 2
Date: Wed, 23 Jun 2004 16:06:00 -0000	[thread overview]
Message-ID: <16601.43621.899821.519555@cuddles.cambridge.redhat.com> (raw)
In-Reply-To: <20040623134742.GA24612@nevyn.them.org>

Daniel Jacobowitz writes:
 > On Wed, Jun 23, 2004 at 12:05:59PM +0100, Andrew Haley wrote:
 > > This patch is now in mainline.  Is there anything else you need?
 > 
 > Yes.  Two sets of questions left, one for Jeff and one [plus a little
 > bit] for you...
 > 
 > 
 > Jeff, one test still fails: calling addprint.  I think this is mostly a
 > GDB problem rather than GCC.  Before starting the program I see this:
 > 
 > (gdb) ptype jvclass
 > type = class jvclass : public java::lang::Object {
 >   public:
 >     static int k;
 > 
 >     static void addprint(int, int, int);
 >     virtual int addk(int);
 > }
 > 
 > Then, after starting it:
 > (gdb) ptype jvclass
 > type = class jvclass  extends java::lang::Object {
 >     public static int k;
 > 
 >     void addprint(int, int, int);
 >     int addk(int);
 >     jvclass();
 >     void <clinit>();
 > }
 > 
 >   - Should we suppress jvclass and <clinit> the way we do for C++
 >     artificial methods?
 > 
 >   - Why is it java::lang::Object instead of java.lang.Object?
 > 
 >   - Why did printing of the type change?  There's only one definition
 >     of jvclass in the debug info, and it's marked Java.
 > 
 > [Andrew, I notice that we've lost the 'static' here.  There's nothing
 > in the dwarf output to express it, so this is a GCC problem.]

OK.

 > The other question: I looked at fixing the debug info to print field
 > names correctly.  The reason it's wrong is that dwarf2out uses the
 > decl_printable_name langhook.  Java doesn't use the second argument,
 > which the common code assumes is verbosity.  Common code always passes
 > '2', which matches what Java's does, except in three places: mudflap
 > (???), the C tree pretty printer, and this call in dwarf2out used to
 > set the name of decls.  Java mostly passes 0 since it knows the value
 > is ignored.  Any reason not to fix up the Java frontend to pass 2,
 > extend the function to handle smaller values, and thus correct the
 > debug output?

Yes, I can do that.

Andrew.


  reply	other threads:[~2004-06-23 16:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-17 20:53 Jeff Johnston
2004-06-11 17:49 ` Jeff Johnston
2004-06-17  3:06 ` Daniel Jacobowitz
2004-06-17 20:52   ` Jeff Johnston
2004-06-19 23:59     ` Daniel Jacobowitz
2004-06-21 10:49       ` Andrew Haley
2004-06-21 15:17       ` Andrew Haley
2004-06-23 11:06         ` Andrew Haley
2004-06-23 13:47           ` Daniel Jacobowitz
2004-06-23 16:06             ` Andrew Haley [this message]
2004-06-23 16:08               ` Daniel Jacobowitz
2004-06-23 21:55             ` Jeff Johnston
2004-06-23 23:01               ` Daniel Jacobowitz
2004-06-24 17:57                 ` Tom Tromey
2004-07-06 21:47                 ` Jeff Johnston
2004-07-26 19:49                   ` Jeff Johnston
2004-07-26 19:51                     ` Daniel Jacobowitz
2004-08-02 10:17                       ` Andrew Haley
2004-08-02 15:17                         ` Andrew Haley
2004-08-02 20:20                           ` Daniel Jacobowitz
2004-08-03 18:45                             ` Andrew Haley
2004-08-16 13:08                               ` Andrew Haley
2004-08-16 13:18                                 ` Daniel Jacobowitz
2004-08-16 20:32                                   ` Daniel Jacobowitz
2004-08-16 20:35                   ` Daniel Jacobowitz
2004-08-24 18:53                     ` [RFA]: Java Inferior Call Take 3 Jeff Johnston
2004-08-24 19:05                       ` Michael Chastain
2004-08-24 19:28                         ` Jeff Johnston
2004-08-24 19:10                       ` Michael Chastain
2004-08-24 19:48                         ` Andrew Cagney
2004-09-01  4:51                       ` Jim Blandy
2004-09-09 23:41                         ` Jeff Johnston
2004-09-10 20:12                           ` Jim Blandy
2004-09-15 22:58                             ` Jeff Johnston
2004-09-20 18:23                               ` Jim Blandy
2004-09-20 20:19                                 ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16601.43621.899821.519555@cuddles.cambridge.redhat.com \
    --to=aph@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox