Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: [PATCH] use "verbose" for notification of not running a test
@ 2003-12-01 18:14 Michael Elizabeth Chastain
  2003-12-03  3:59 ` Andrew Cagney
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Elizabeth Chastain @ 2003-12-01 18:14 UTC (permalink / raw)
  To: cagney, fnf; +Cc: drow, gdb-patches

ac> At present it prints:
ac> 
ac> WARNING: Assembly source test -- multilibs not supported by this test.
ac> 
ac> then skips everything.  That way the fact that the test was 
ac> intentionally skipped is recorded in the test logs - makes comparing 
ac> test results easier.

Except that dejagnu doesn't print ERROR and WARNING and NOTE counts
in the totals at the end, so lots of people don't notice if they get
one of those.  I wish these people would change, and I wish dejagnu
would change, too.

How about making this an UNSUPPORTED?

Michael C


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] use "verbose" for notification of not running a test
@ 2003-12-03  5:25 Michael Elizabeth Chastain
  2003-12-03 16:17 ` Andrew Cagney
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Elizabeth Chastain @ 2003-12-03  5:25 UTC (permalink / raw)
  To: cagney, fnf; +Cc: drow, gdb-patches

> gdb.arch/altivec-abi.exp:    verbose "Skipping altivec abi tests."
> gdb.arch/altivec-regs.exp:    verbose "Skipping altivec register tests."
> gdb.arch/e500-abi.exp:    verbose "Skipping e500 abi tests."
> gdb.arch/e500-regs.exp:    verbose "Skipping e500 register tests."
> gdb.arch/gdb1291.exp:    verbose "Skipping SH backtrace tests."
> gdb.arch/gdb1431.exp:    verbose "Skipping SH backtrace tests."
> gdb.arch/i386-prologue.exp:    verbose "Skipping i386 prologue tests."
> gdb.arch/i386-unwind.exp:    verbose "Skipping i386 unwinder tests."

Hmmm.  These are all conditioned on target architecture.

My first reaction is that it's good to have arch-specific tests.
It would be silly to pretend that gdb has the same features on all
architectures.  It's a debugger, not a web server or a text editor!

My second reaction is that when I run an sh-*-* test on native
i686-pc-linux-gnu, I don't need to see an UNSUPPORTED about it.

So the existing "verbose ... / return" works for me.

> gdb.base/a2-run.exp:    verbose "Skipping a2-run.exp because of noargs."

Yes, I think this is a good place for UNSUPPORTED.

"noargs" is either a limitation of the test environment or of the
toolchain.  If it's a limitation of the test environment, I think
that UNSUPPORTED matches it.  If it's a limitation of the toolchain,
then it's actually a bit of a cheat to set "noargs", but UNSUPPORTED
would not be too bad.

A casual look at dejagnu/baseboards.exp and "noargs" makes me think
that "noargs" is generally a property of the test board, not a
property of the toolchain.

The dejagnu doco says:

  UNSUPPORTED
  A test depends on a conditionally available feature that does not
  exist (in the configured testing environment).  For example, you can
  use this outcome to report on a test case that does not work on a
  particular target because its operating system support does not
  include a required subroutine.

To me, the things in gdb.arch are not "conditionally available" on
non-matching targets; they are just plain unavailable.

And if the limit is in the toolchain rather than the testing
environment, it is really a FAIL, not an UNSUPPORTED.  UNIMPLEMENTED
would be more accurate but there is no such word, so I'm not too
hurt by fudging UNSUPPORTED to mean "unsupported by the toolchain"
as well as "unsupported by the test environment" from time to time.

What do other people think?

Michael C


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] use "verbose" for notification of not running a test
@ 2003-12-03  5:05 Michael Elizabeth Chastain
  0 siblings, 0 replies; 11+ messages in thread
From: Michael Elizabeth Chastain @ 2003-12-03  5:05 UTC (permalink / raw)
  To: cagney, mec.gnu; +Cc: drow, fnf, gdb-patches

mec> How about making this an UNSUPPORTED?
ac> It is supported, it's just not being tested ... :-(

Whoops, you caught me!

UNSUPPORTED should always mean "unsupported in gdb",
but I was attempting to use it to mean "unsupported in the test suite".

gdb and the test suite are not symmetric at all; in fact they are
adverserial.

Michael C


^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] use "verbose" for notification of not running a test
@ 2003-11-29 22:25 Fred Fish
  2003-11-29 23:29 ` Daniel Jacobowitz
  0 siblings, 1 reply; 11+ messages in thread
From: Fred Fish @ 2003-11-29 22:25 UTC (permalink / raw)
  To: gdb-patches; +Cc: fnf

Other places in the testsuite where tests are not run based on the
target or it's capabilities use "verbose" to notify the user.  The
suppression mechanisms are generally reserved for short circuiting
future tests when a failure of some kind is observed when attempting a
test.


2003-11-29  Fred Fish  <fnf@redhat.com>

	* gdb.asm/asm-source.exp: Use "verbose" when not running
	assembly tests or not supporting multilib.


Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.44
diff -c -p -r1.44 asm-source.exp
*** gdb.asm/asm-source.exp	26 Nov 2003 01:17:16 -0000	1.44
--- gdb.asm/asm-source.exp	29 Nov 2003 22:22:01 -0000
*************** switch -glob -- [istarget] {
*** 111,117 ****
  }
  
  if { "${asm-arch}" == "" } {
!     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of
--- 111,118 ----
  }
  
  if { "${asm-arch}" == "" } {
!     verbose "Assembly source test -- not implemented for this target."
!     return;
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of
*************** set dest [target_info name]
*** 134,140 ****
  if [board_info $dest exists multilib_flags] {
  	set multilib_flags [board_info $dest multilib_flags]
  	if { "${multilib_flags}" != "" } {
! 	   gdb_suppress_entire_file "Assembly source test -- multilibs not supported by this test."
  	   return;
  	 }
  }
--- 135,141 ----
  if [board_info $dest exists multilib_flags] {
  	set multilib_flags [board_info $dest multilib_flags]
  	if { "${multilib_flags}" != "" } {
! 	   verbose "Assembly source test -- multilibs not supported by this test."
  	   return;
  	 }
  }


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2003-12-03 16:17 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-01 18:14 [PATCH] use "verbose" for notification of not running a test Michael Elizabeth Chastain
2003-12-03  3:59 ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2003-12-03  5:25 Michael Elizabeth Chastain
2003-12-03 16:17 ` Andrew Cagney
2003-12-03  5:05 Michael Elizabeth Chastain
2003-11-29 22:25 Fred Fish
2003-11-29 23:29 ` Daniel Jacobowitz
2003-11-30  5:46   ` Fred Fish
2003-12-01 17:44     ` Andrew Cagney
2003-12-01 18:17       ` Fred Fish
2003-12-03  4:01         ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox