From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32125 invoked by alias); 29 Nov 2003 23:29:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32112 invoked from network); 29 Nov 2003 23:29:21 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 29 Nov 2003 23:29:21 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AQEWe-0006cI-KQ; Sat, 29 Nov 2003 18:29:20 -0500 Date: Sat, 29 Nov 2003 23:29:00 -0000 From: Daniel Jacobowitz To: fnf@ninemoons.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] use "verbose" for notification of not running a test Message-ID: <20031129232920.GA25398@nevyn.them.org> Mail-Followup-To: fnf@ninemoons.com, gdb-patches@sources.redhat.com References: <200311292224.hATMOsDa031308@fred.ninemoons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311292224.hATMOsDa031308@fred.ninemoons.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00624.txt.bz2 On Sat, Nov 29, 2003 at 03:24:54PM -0700, Fred Fish wrote: > Other places in the testsuite where tests are not run based on the > target or it's capabilities use "verbose" to notify the user. The > suppression mechanisms are generally reserved for short circuiting > future tests when a failure of some kind is observed when attempting a > test. > > > 2003-11-29 Fred Fish > > * gdb.asm/asm-source.exp: Use "verbose" when not running > assembly tests or not supporting multilib. Hmm... I'd rather not. In general, I'm all in favor of destroying calls to gdb_suppress_entire_file. However, most other tests are skipped because of some serious lack in GDB or the available OS services, not because the test needs a quick port to that architecture. The asm-source.exp suppression was left messy to encourage people to write the appropriate wrappers; it's really not hard to do. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer