From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22529 invoked by alias); 1 Dec 2003 18:17:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22505 invoked from network); 1 Dec 2003 18:17:01 -0000 Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217) by sources.redhat.com with SMTP; 1 Dec 2003 18:17:01 -0000 Received: from fred.ninemoons.com (fred.ninemoons.com [127.0.0.1]) by fred.ninemoons.com (8.12.8/8.12.8) with ESMTP id hB1IGPXj030386; Mon, 1 Dec 2003 11:16:25 -0700 Received: (from fnf@localhost) by fred.ninemoons.com (8.12.8/8.12.8/Submit) id hB1IGOgw030384; Mon, 1 Dec 2003 11:16:24 -0700 From: Fred Fish Message-Id: <200312011816.hB1IGOgw030384@fred.ninemoons.com> Subject: Re: [PATCH] use "verbose" for notification of not running a test To: cagney@gnu.org (Andrew Cagney) Date: Mon, 01 Dec 2003 18:17:00 -0000 Cc: fnf@ninemoons.com, drow@mvista.com (Daniel Jacobowitz), gdb-patches@sources.redhat.com Reply-To: fnf@ninemoons.com In-Reply-To: <3FCB7DE9.2030607@gnu.org> from "Andrew Cagney" at Dec 01, 2003 12:44:09 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00021.txt.bz2 > At present it prints: > > WARNING: Assembly source test -- multilibs not supported by this test. > > then skips everything. That way the fact that the test was > intentionally skipped is recorded in the test logs - makes comparing > test results easier. I just thought it was inconsistent with all the other places that skip tests due to something other than a failure in a prior test, compilation failure, or some other failing event. Here are some examples that have "skip" in their message: gdb.arch/altivec-abi.exp: verbose "Skipping altivec abi tests." gdb.arch/altivec-regs.exp: verbose "Skipping altivec register tests." gdb.arch/e500-abi.exp: verbose "Skipping e500 abi tests." gdb.arch/e500-regs.exp: verbose "Skipping e500 register tests." gdb.arch/gdb1291.exp: verbose "Skipping SH backtrace tests." gdb.arch/gdb1431.exp: verbose "Skipping SH backtrace tests." gdb.arch/i386-prologue.exp: verbose "Skipping i386 prologue tests." gdb.arch/i386-unwind.exp: verbose "Skipping i386 unwinder tests." gdb.base/a2-run.exp: verbose "Skipping a2-run.exp because of noargs." gdb.base/commands.exp: verbose "Skipping progvar_simple_if_test because of noargs." gdb.base/commands.exp: verbose "Skipping progvar_simple_while_test because of noargs." gdb.base/commands.exp: verbose "Skipping progvar_simple_if_while_test because of noargs." gdb.base/commands.exp: verbose "Skipping if_while_breakpoint_command_test because of noargs." gdb.base/commands.exp: verbose "Skipping infrun_breakpoint_command_test because of noargs." gdb.base/commands.exp: verbose "Skipping breakpoint_command_test because of noargs." gdb.base/commands.exp: verbose "Skipping watchpoint_command_test because of noargs." gdb.base/commands.exp: verbose "Skipping test_command_prompt_position because of noargs." gdb.base/commands.exp: verbose "Skipping bp_deleted_in_command_test because of noargs." gdb.base/commands.exp: verbose "Skipping temporary_breakpoint_commands because of noargs." gdb.base/fileio.exp: verbose "Skipping fileio.exp because of no fileio capabilities." gdb.base/interrupt.exp: verbose "Skipping interrupt.exp because of nointerrupts." gdb.base/interrupt.exp: verbose "Skipping interrupt.exp because of noinferiorio." gdb.base/overlays.exp: verbose "Skipping overlay test -- not implemented for this target." gdb.base/shreloc.exp: verbose "test skipped - shared object files not supported by this target." gdb.base/sigall.exp: verbose "Skipping sigall.exp because of nosignals." gdb.base/signals.exp: verbose "Skipping signals.exp because of nosignals." gdb.gdbtk/cpp_variable.exp: verbose "No C++ support -- skipping test" gdb.mi/mi2-syn-frame.exp: verbose "Skipping mi-syn-frame.exp because of nosignals." gdb.mi/mi-syn-frame.exp: verbose "Skipping mi-syn-frame.exp because of nosignals." -Fred