From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-28962-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 722 invoked by alias); 29 Nov 2003 22:25:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 594 invoked from network); 29 Nov 2003 22:24:59 -0000
Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217)
  by sources.redhat.com with SMTP; 29 Nov 2003 22:24:59 -0000
Received: from fred.ninemoons.com (fred.ninemoons.com [127.0.0.1])
	by fred.ninemoons.com (8.12.8/8.12.8) with ESMTP id hATMOtXj031328;
	Sat, 29 Nov 2003 15:24:55 -0700
Received: (from fnf@localhost)
	by fred.ninemoons.com (8.12.8/8.12.8/Submit) id hATMOsDa031308;
	Sat, 29 Nov 2003 15:24:54 -0700
From: Fred Fish <fnf@public.ninemoons.com>
Message-Id: <200311292224.hATMOsDa031308@fred.ninemoons.com>
Subject: [PATCH] use "verbose" for notification of not running a test
To: gdb-patches@sources.redhat.com
Date: Sat, 29 Nov 2003 22:25:00 -0000
Cc: fnf@ninemoons.com
Reply-To: fnf@ninemoons.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-11/txt/msg00622.txt.bz2

Other places in the testsuite where tests are not run based on the
target or it's capabilities use "verbose" to notify the user.  The
suppression mechanisms are generally reserved for short circuiting
future tests when a failure of some kind is observed when attempting a
test.


2003-11-29  Fred Fish  <fnf@redhat.com>

	* gdb.asm/asm-source.exp: Use "verbose" when not running
	assembly tests or not supporting multilib.


Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.44
diff -c -p -r1.44 asm-source.exp
*** gdb.asm/asm-source.exp	26 Nov 2003 01:17:16 -0000	1.44
--- gdb.asm/asm-source.exp	29 Nov 2003 22:22:01 -0000
*************** switch -glob -- [istarget] {
*** 111,117 ****
  }
  
  if { "${asm-arch}" == "" } {
!     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of
--- 111,118 ----
  }
  
  if { "${asm-arch}" == "" } {
!     verbose "Assembly source test -- not implemented for this target."
!     return;
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of
*************** set dest [target_info name]
*** 134,140 ****
  if [board_info $dest exists multilib_flags] {
  	set multilib_flags [board_info $dest multilib_flags]
  	if { "${multilib_flags}" != "" } {
! 	   gdb_suppress_entire_file "Assembly source test -- multilibs not supported by this test."
  	   return;
  	 }
  }
--- 135,141 ----
  if [board_info $dest exists multilib_flags] {
  	set multilib_flags [board_info $dest multilib_flags]
  	if { "${multilib_flags}" != "" } {
! 	   verbose "Assembly source test -- multilibs not supported by this test."
  	   return;
  	 }
  }