From: Andrew Cagney <cagney@gnu.org>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: fnf@ninemoons.com, drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] use "verbose" for notification of not running a test
Date: Wed, 03 Dec 2003 16:17:00 -0000 [thread overview]
Message-ID: <3FCE0C94.2050007@gnu.org> (raw)
In-Reply-To: <20031203052445.DF66E4B35B@berman.michael-chastain.com>
>> gdb.arch/altivec-abi.exp: verbose "Skipping altivec abi tests."
>> gdb.arch/altivec-regs.exp: verbose "Skipping altivec register tests."
>> gdb.arch/e500-abi.exp: verbose "Skipping e500 abi tests."
>> gdb.arch/e500-regs.exp: verbose "Skipping e500 register tests."
>> gdb.arch/gdb1291.exp: verbose "Skipping SH backtrace tests."
>> gdb.arch/gdb1431.exp: verbose "Skipping SH backtrace tests."
>> gdb.arch/i386-prologue.exp: verbose "Skipping i386 prologue tests."
>> gdb.arch/i386-unwind.exp: verbose "Skipping i386 unwinder tests."
>
>
> Hmmm. These are all conditioned on target architecture.
>
> My first reaction is that it's good to have arch-specific tests.
> It would be silly to pretend that gdb has the same features on all
> architectures. It's a debugger, not a web server or a text editor!
>
> My second reaction is that when I run an sh-*-* test on native
> i686-pc-linux-gnu, I don't need to see an UNSUPPORTED about it.
>
> So the existing "verbose ... / return" works for me.
>
>
>> gdb.base/a2-run.exp: verbose "Skipping a2-run.exp because of noargs."
>
>
> Yes, I think this is a good place for UNSUPPORTED.
>
> "noargs" is either a limitation of the test environment or of the
> toolchain. If it's a limitation of the test environment, I think
> that UNSUPPORTED matches it. If it's a limitation of the toolchain,
> then it's actually a bit of a cheat to set "noargs", but UNSUPPORTED
> would not be too bad.
>
> A casual look at dejagnu/baseboards.exp and "noargs" makes me think
> that "noargs" is generally a property of the test board, not a
> property of the toolchain.
>
> The dejagnu doco says:
>
> UNSUPPORTED
> A test depends on a conditionally available feature that does not
> exist (in the configured testing environment). For example, you can
> use this outcome to report on a test case that does not work on a
> particular target because its operating system support does not
> include a required subroutine.
>
> To me, the things in gdb.arch are not "conditionally available" on
> non-matching targets; they are just plain unavailable.
>
> And if the limit is in the toolchain rather than the testing
> environment, it is really a FAIL, not an UNSUPPORTED. UNIMPLEMENTED
> would be more accurate but there is no such word, so I'm not too
> hurt by fudging UNSUPPORTED to mean "unsupported by the toolchain"
> as well as "unsupported by the test environment" from time to time.
Unimplemented is, in a sense, equivalent to KFAIL. It fails because
someone hasn't fixed it.
Here, though, its fuzzy.
For some baseboards it really can't be implemented - cases where the
"osabi" (I use the term loosely given its a baseboard) doesn't define
the the mechanism for passing argv to the starting program for others it
may be possible, just that no one is motivated to do it.
However, UNSUPPORTED may be sufficient. What ever :-)
Andrew
> What do other people think?
>
> Michael C
>
next prev parent reply other threads:[~2003-12-03 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-03 5:25 Michael Elizabeth Chastain
2003-12-03 16:17 ` Andrew Cagney [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-03 5:05 Michael Elizabeth Chastain
2003-12-01 18:14 Michael Elizabeth Chastain
2003-12-03 3:59 ` Andrew Cagney
2003-11-29 22:25 Fred Fish
2003-11-29 23:29 ` Daniel Jacobowitz
2003-11-30 5:46 ` Fred Fish
2003-12-01 17:44 ` Andrew Cagney
2003-12-01 18:17 ` Fred Fish
2003-12-03 4:01 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FCE0C94.2050007@gnu.org \
--to=cagney@gnu.org \
--cc=drow@mvista.com \
--cc=fnf@ninemoons.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox