[RFC] [PATCH 0/1] Add untested for corefile tests

[RFC] [PATCH 0/1] Add untested for corefile tests

[Christina Schimpe]

This is a patch to add UNTESTED for corefile tests in case an OS corefile is
not found or is not created.  The discussion came up in this thread:

https://sourceware.org/pipermail/gdb-patches/2025-August/219807.html
and there are mixed opinions how we should treat this.

In my opinion, UNTESTED means that there is something wrong with the setup
and one should investigate, while UNSUPPORTED means it's acceptable for the
test to be skipped.  However, I also understand Luis' feedback to add a FAIL,
since this strongly indicates that there is something we should look into.
However, if we test a patch and only check the new failures introduced by
the commit, there is a risk that someone might not realize he is not testing
core files at all.

We also have a wiki entry for this topic:
https://sourceware.org/gdb/wiki/TestingGDB

But it's also not completely clear on this specific question:
"GDB testsuite expects that corefile will be generated on the same folder of
the binary used on the test, when Apport is enabled, it can result in a FAIL/UNTESTED
since Apport collects the corefile generated and corefind function in GDB
testsuite is unable to find it".

In any case I think we should make this consistent in our testsuite and
I am looking forward to your feedback.

Christina


Christina Schimpe (1):
  testsuite: add unsupported in case OS corefile is not found

 gdb/testsuite/gdb.base/corefile.exp       | 1 +
 gdb/testsuite/gdb.base/corefile2.exp      | 1 +
 gdb/testsuite/gdb.base/corefile3.exp      | 1 +
 gdb/testsuite/gdb.base/many-headers.exp   | 1 +
 gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
 gdb/testsuite/gdb.threads/corethreads.exp | 1 +
 6 files changed, 6 insertions(+)

-- 
2.43.0

[PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Christina Schimpe]

Even though the core_find proc will log a warning, it's better to log
"unsupported" and then terminate the test.  This will help to avoid
silently skipped tests, when running the testsuite.  Most of the tests
already do that.  This patch adds the missing ones.
---
 gdb/testsuite/gdb.base/corefile.exp       | 1 +
 gdb/testsuite/gdb.base/corefile2.exp      | 1 +
 gdb/testsuite/gdb.base/corefile3.exp      | 1 +
 gdb/testsuite/gdb.base/many-headers.exp   | 1 +
 gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
 gdb/testsuite/gdb.threads/corethreads.exp | 1 +
 6 files changed, 6 insertions(+)

diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
index da1fdf3517c..fd8d1d1274c 100644
--- a/gdb/testsuite/gdb.base/corefile.exp
+++ b/gdb/testsuite/gdb.base/corefile.exp
@@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 # mmapped data in core file" test.
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp
index 392705b5930..d35ba1a1295 100644
--- a/gdb/testsuite/gdb.base/corefile2.exp
+++ b/gdb/testsuite/gdb.base/corefile2.exp
@@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp
index 57b230004b6..ef391d15049 100644
--- a/gdb/testsuite/gdb.base/corefile3.exp
+++ b/gdb/testsuite/gdb.base/corefile3.exp
@@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return
 }
 
diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp
index f46b9800cf9..5e022da8534 100644
--- a/gdb/testsuite/gdb.base/many-headers.exp
+++ b/gdb/testsuite/gdb.base/many-headers.exp
@@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
 # Generate core file.
 set corefile [core_find $binfile]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp
index 3f0e7202330..b4914866dfc 100644
--- a/gdb/testsuite/gdb.mi/mi-corefile.exp
+++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
@@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp
index 3b50ae3a3cd..0011dc3547c 100644
--- a/gdb/testsuite/gdb.threads/corethreads.exp
+++ b/gdb/testsuite/gdb.threads/corethreads.exp
@@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
 
 set corefile [core_find $binfile]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
-- 
2.43.0

RE: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Schimpe, Christina]

> -----Original Message-----
> From: Christina Schimpe <christina.schimpe@intel.com>
> Sent: Monday, August 11, 2025 1:44 PM
> To: gdb-patches@sourceware.org
> Cc: thiago.bauermann@linaro.org; luis.machado.foss@gmail.com
> Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not
> found
> 
> Even though the core_find proc will log a warning, it's better to log
> "unsupported" and then terminate the test.  This will help to avoid silently
> skipped tests, when running the testsuite.  Most of the tests already do
> that.  This patch adds the missing ones.
> ---
>  gdb/testsuite/gdb.base/corefile.exp       | 1 +
>  gdb/testsuite/gdb.base/corefile2.exp      | 1 +
>  gdb/testsuite/gdb.base/corefile3.exp      | 1 +
>  gdb/testsuite/gdb.base/many-headers.exp   | 1 +
>  gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
>  gdb/testsuite/gdb.threads/corethreads.exp | 1 +
>  6 files changed, 6 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/corefile.exp
> b/gdb/testsuite/gdb.base/corefile.exp
> index da1fdf3517c..fd8d1d1274c 100644
> --- a/gdb/testsuite/gdb.base/corefile.exp
> +++ b/gdb/testsuite/gdb.base/corefile.exp
> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
> debug] == -1} {  # mmapped data in core file" test.
>  set corefile [core_find $binfile {}]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return 0
>  }
> 
> diff --git a/gdb/testsuite/gdb.base/corefile2.exp
> b/gdb/testsuite/gdb.base/corefile2.exp
> index 392705b5930..d35ba1a1295 100644
> --- a/gdb/testsuite/gdb.base/corefile2.exp
> +++ b/gdb/testsuite/gdb.base/corefile2.exp
> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
> debug] == -1} {
> 
>  set corefile [core_find $binfile {}]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return 0
>  }
> 
> diff --git a/gdb/testsuite/gdb.base/corefile3.exp
> b/gdb/testsuite/gdb.base/corefile3.exp
> index 57b230004b6..ef391d15049 100644
> --- a/gdb/testsuite/gdb.base/corefile3.exp
> +++ b/gdb/testsuite/gdb.base/corefile3.exp
> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -
> 1} {
> 
>  set corefile [core_find $binfile {}]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return
>  }
> 
> diff --git a/gdb/testsuite/gdb.base/many-headers.exp
> b/gdb/testsuite/gdb.base/many-headers.exp
> index f46b9800cf9..5e022da8534 100644
> --- a/gdb/testsuite/gdb.base/many-headers.exp
> +++ b/gdb/testsuite/gdb.base/many-headers.exp
> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile
> $srcfile debug]} {  # Generate core file.
>  set corefile [core_find $binfile]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return 0
>  }
> 
> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-
> corefile.exp
> index 3f0e7202330..b4914866dfc 100644
> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
> debug] == -1} {
> 
>  set corefile [core_find $binfile {}]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return 0
>  }
> 
> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp
> b/gdb/testsuite/gdb.threads/corethreads.exp
> index 3b50ae3a3cd..0011dc3547c 100644
> --- a/gdb/testsuite/gdb.threads/corethreads.exp
> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads
> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
> 
>  set corefile [core_find $binfile]
>  if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>      return 0
>  }
> 
> --
> 2.43.0

I have been a bit too quick here :/, I meant untested instead of unsupported in the commit message.
Will fix this once we agreed on the right approach.

Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Luis]

Hi Christina,


On 8/11/25 12:44, Christina Schimpe wrote:
> Even though the core_find proc will log a warning, it's better to log
> "unsupported" and then terminate the test.  This will help to avoid

Did you mean untested here instead of unsupported, based on the code below?

> silently skipped tests, when running the testsuite.  Most of the tests
> already do that.  This patch adds the missing ones.
> ---
>   gdb/testsuite/gdb.base/corefile.exp       | 1 +
>   gdb/testsuite/gdb.base/corefile2.exp      | 1 +
>   gdb/testsuite/gdb.base/corefile3.exp      | 1 +
>   gdb/testsuite/gdb.base/many-headers.exp   | 1 +
>   gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
>   gdb/testsuite/gdb.threads/corethreads.exp | 1 +
>   6 files changed, 6 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
> index da1fdf3517c..fd8d1d1274c 100644
> --- a/gdb/testsuite/gdb.base/corefile.exp
> +++ b/gdb/testsuite/gdb.base/corefile.exp
> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
>   # mmapped data in core file" test.
>   set corefile [core_find $binfile {}]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return 0
>   }
>   
> diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp
> index 392705b5930..d35ba1a1295 100644
> --- a/gdb/testsuite/gdb.base/corefile2.exp
> +++ b/gdb/testsuite/gdb.base/corefile2.exp
> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
>   
>   set corefile [core_find $binfile {}]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return 0
>   }
>   
> diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp
> index 57b230004b6..ef391d15049 100644
> --- a/gdb/testsuite/gdb.base/corefile3.exp
> +++ b/gdb/testsuite/gdb.base/corefile3.exp
> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} {
>   
>   set corefile [core_find $binfile {}]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return
>   }
>   
> diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp
> index f46b9800cf9..5e022da8534 100644
> --- a/gdb/testsuite/gdb.base/many-headers.exp
> +++ b/gdb/testsuite/gdb.base/many-headers.exp
> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
>   # Generate core file.
>   set corefile [core_find $binfile]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return 0
>   }
>   
> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp
> index 3f0e7202330..b4914866dfc 100644
> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
>   
>   set corefile [core_find $binfile {}]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return 0
>   }
>   
> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp
> index 3b50ae3a3cd..0011dc3547c 100644
> --- a/gdb/testsuite/gdb.threads/corethreads.exp
> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
>   
>   set corefile [core_find $binfile]
>   if {$corefile == ""} {
> +    untested "unable to create or find corefile"
>       return 0
>   }
>   

Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Luis]

On 8/11/25 12:48, Schimpe, Christina wrote:
>> -----Original Message-----
>> From: Christina Schimpe <christina.schimpe@intel.com>
>> Sent: Monday, August 11, 2025 1:44 PM
>> To: gdb-patches@sourceware.org
>> Cc: thiago.bauermann@linaro.org; luis.machado.foss@gmail.com
>> Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not
>> found
>>
>> Even though the core_find proc will log a warning, it's better to log
>> "unsupported" and then terminate the test.  This will help to avoid silently
>> skipped tests, when running the testsuite.  Most of the tests already do
>> that.  This patch adds the missing ones.
>> ---
>>   gdb/testsuite/gdb.base/corefile.exp       | 1 +
>>   gdb/testsuite/gdb.base/corefile2.exp      | 1 +
>>   gdb/testsuite/gdb.base/corefile3.exp      | 1 +
>>   gdb/testsuite/gdb.base/many-headers.exp   | 1 +
>>   gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
>>   gdb/testsuite/gdb.threads/corethreads.exp | 1 +
>>   6 files changed, 6 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.base/corefile.exp
>> b/gdb/testsuite/gdb.base/corefile.exp
>> index da1fdf3517c..fd8d1d1274c 100644
>> --- a/gdb/testsuite/gdb.base/corefile.exp
>> +++ b/gdb/testsuite/gdb.base/corefile.exp
>> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
>> debug] == -1} {  # mmapped data in core file" test.
>>   set corefile [core_find $binfile {}]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return 0
>>   }
>>
>> diff --git a/gdb/testsuite/gdb.base/corefile2.exp
>> b/gdb/testsuite/gdb.base/corefile2.exp
>> index 392705b5930..d35ba1a1295 100644
>> --- a/gdb/testsuite/gdb.base/corefile2.exp
>> +++ b/gdb/testsuite/gdb.base/corefile2.exp
>> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
>> debug] == -1} {
>>
>>   set corefile [core_find $binfile {}]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return 0
>>   }
>>
>> diff --git a/gdb/testsuite/gdb.base/corefile3.exp
>> b/gdb/testsuite/gdb.base/corefile3.exp
>> index 57b230004b6..ef391d15049 100644
>> --- a/gdb/testsuite/gdb.base/corefile3.exp
>> +++ b/gdb/testsuite/gdb.base/corefile3.exp
>> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -
>> 1} {
>>
>>   set corefile [core_find $binfile {}]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return
>>   }
>>
>> diff --git a/gdb/testsuite/gdb.base/many-headers.exp
>> b/gdb/testsuite/gdb.base/many-headers.exp
>> index f46b9800cf9..5e022da8534 100644
>> --- a/gdb/testsuite/gdb.base/many-headers.exp
>> +++ b/gdb/testsuite/gdb.base/many-headers.exp
>> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile
>> $srcfile debug]} {  # Generate core file.
>>   set corefile [core_find $binfile]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return 0
>>   }
>>
>> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-
>> corefile.exp
>> index 3f0e7202330..b4914866dfc 100644
>> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
>> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
>> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile
>> debug] == -1} {
>>
>>   set corefile [core_find $binfile {}]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return 0
>>   }
>>
>> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp
>> b/gdb/testsuite/gdb.threads/corethreads.exp
>> index 3b50ae3a3cd..0011dc3547c 100644
>> --- a/gdb/testsuite/gdb.threads/corethreads.exp
>> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
>> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads
>> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
>>
>>   set corefile [core_find $binfile]
>>   if {$corefile == ""} {
>> +    untested "unable to create or find corefile"
>>       return 0
>>   }
>>
>> --
>> 2.43.0
> 
> I have been a bit too quick here :/, I meant untested instead of unsupported in the commit message.

Heh, I should've read the thread until the end, as I had spotted this. :-)

> Will fix this once we agreed on the right approach.

Though I was the one suggesting a FAIL would be useful, I don't feel 
strongly about it. Let's go with UNTESTED and then we can standardize
it that way across the board.

Your patch is OK with the unsupported/untested fixed.

Approved-By: Luis Machado <luis.machado.foss@gmail.com>

RE: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Schimpe, Christina]

Hi Luis, 

Thank you for the review. 
I spotted one more instance in break-interp.exp:

--- a/gdb/testsuite/gdb.base/break-interp.exp
+++ b/gdb/testsuite/gdb.base/break-interp.exp
@@ -218,6 +218,7 @@ proc test_core {file displacement} {
 
        set corefile [core_find $file {} "segv"]
        if {$corefile == ""} {
+           untested "unable to create or find corefile"
            return
        }

which I'd include in the patch. 
With the fix for UNTESTED  in the commit message I'll push this by tomorrow, if there are no concerns. 😊

Kind Regards,
Christina

> -----Original Message-----
> From: Luis <luis.machado.foss@gmail.com>
> Sent: Tuesday, August 19, 2025 1:00 AM
> To: Schimpe, Christina <christina.schimpe@intel.com>; gdb-
> patches@sourceware.org
> Cc: thiago.bauermann@linaro.org
> Subject: Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is
> not found
> 
> On 8/11/25 12:48, Schimpe, Christina wrote:
> >> -----Original Message-----
> >> From: Christina Schimpe <christina.schimpe@intel.com>
> >> Sent: Monday, August 11, 2025 1:44 PM
> >> To: gdb-patches@sourceware.org
> >> Cc: thiago.bauermann@linaro.org; luis.machado.foss@gmail.com
> >> Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile
> >> is not found
> >>
> >> Even though the core_find proc will log a warning, it's better to log
> >> "unsupported" and then terminate the test.  This will help to avoid
> >> silently skipped tests, when running the testsuite.  Most of the
> >> tests already do that.  This patch adds the missing ones.
> >> ---
> >>   gdb/testsuite/gdb.base/corefile.exp       | 1 +
> >>   gdb/testsuite/gdb.base/corefile2.exp      | 1 +
> >>   gdb/testsuite/gdb.base/corefile3.exp      | 1 +
> >>   gdb/testsuite/gdb.base/many-headers.exp   | 1 +
> >>   gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
> >>   gdb/testsuite/gdb.threads/corethreads.exp | 1 +
> >>   6 files changed, 6 insertions(+)
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile.exp
> >> b/gdb/testsuite/gdb.base/corefile.exp
> >> index da1fdf3517c..fd8d1d1274c 100644
> >> --- a/gdb/testsuite/gdb.base/corefile.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile.exp
> >> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {  # mmapped data in core file" test.
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile2.exp
> >> b/gdb/testsuite/gdb.base/corefile2.exp
> >> index 392705b5930..d35ba1a1295 100644
> >> --- a/gdb/testsuite/gdb.base/corefile2.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile2.exp
> >> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile3.exp
> >> b/gdb/testsuite/gdb.base/corefile3.exp
> >> index 57b230004b6..ef391d15049 100644
> >> --- a/gdb/testsuite/gdb.base/corefile3.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile3.exp
> >> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile] == - 1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/many-headers.exp
> >> b/gdb/testsuite/gdb.base/many-headers.exp
> >> index f46b9800cf9..5e022da8534 100644
> >> --- a/gdb/testsuite/gdb.base/many-headers.exp
> >> +++ b/gdb/testsuite/gdb.base/many-headers.exp
> >> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile
> >> $srcfile debug]} {  # Generate core file.
> >>   set corefile [core_find $binfile]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> b/gdb/testsuite/gdb.mi/mi- corefile.exp index
> >> 3f0e7202330..b4914866dfc 100644
> >> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp
> >> b/gdb/testsuite/gdb.threads/corethreads.exp
> >> index 3b50ae3a3cd..0011dc3547c 100644
> >> --- a/gdb/testsuite/gdb.threads/corethreads.exp
> >> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
> >> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads
> >> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
> >>
> >>   set corefile [core_find $binfile]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> --
> >> 2.43.0
> >
> > I have been a bit too quick here :/, I meant untested instead of
> unsupported in the commit message.
> 
> Heh, I should've read the thread until the end, as I had spotted this. :-)
> 
> > Will fix this once we agreed on the right approach.
> 
> Though I was the one suggesting a FAIL would be useful, I don't feel strongly
> about it. Let's go with UNTESTED and then we can standardize it that way
> across the board.
> 
> Your patch is OK with the unsupported/untested fixed.
> 
> Approved-By: Luis Machado <luis.machado.foss@gmail.com>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

RE: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

[Schimpe, Christina]

I finally pushed this.

Christina

> -----Original Message-----
> From: Luis <luis.machado.foss@gmail.com>
> Sent: Tuesday, August 19, 2025 1:00 AM
> To: Schimpe, Christina <christina.schimpe@intel.com>; gdb-
> patches@sourceware.org
> Cc: thiago.bauermann@linaro.org
> Subject: Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is
> not found
> 
> On 8/11/25 12:48, Schimpe, Christina wrote:
> >> -----Original Message-----
> >> From: Christina Schimpe <christina.schimpe@intel.com>
> >> Sent: Monday, August 11, 2025 1:44 PM
> >> To: gdb-patches@sourceware.org
> >> Cc: thiago.bauermann@linaro.org; luis.machado.foss@gmail.com
> >> Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile
> >> is not found
> >>
> >> Even though the core_find proc will log a warning, it's better to log
> >> "unsupported" and then terminate the test.  This will help to avoid
> >> silently skipped tests, when running the testsuite.  Most of the
> >> tests already do that.  This patch adds the missing ones.
> >> ---
> >>   gdb/testsuite/gdb.base/corefile.exp       | 1 +
> >>   gdb/testsuite/gdb.base/corefile2.exp      | 1 +
> >>   gdb/testsuite/gdb.base/corefile3.exp      | 1 +
> >>   gdb/testsuite/gdb.base/many-headers.exp   | 1 +
> >>   gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
> >>   gdb/testsuite/gdb.threads/corethreads.exp | 1 +
> >>   6 files changed, 6 insertions(+)
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile.exp
> >> b/gdb/testsuite/gdb.base/corefile.exp
> >> index da1fdf3517c..fd8d1d1274c 100644
> >> --- a/gdb/testsuite/gdb.base/corefile.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile.exp
> >> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {  # mmapped data in core file" test.
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile2.exp
> >> b/gdb/testsuite/gdb.base/corefile2.exp
> >> index 392705b5930..d35ba1a1295 100644
> >> --- a/gdb/testsuite/gdb.base/corefile2.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile2.exp
> >> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/corefile3.exp
> >> b/gdb/testsuite/gdb.base/corefile3.exp
> >> index 57b230004b6..ef391d15049 100644
> >> --- a/gdb/testsuite/gdb.base/corefile3.exp
> >> +++ b/gdb/testsuite/gdb.base/corefile3.exp
> >> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile] == - 1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.base/many-headers.exp
> >> b/gdb/testsuite/gdb.base/many-headers.exp
> >> index f46b9800cf9..5e022da8534 100644
> >> --- a/gdb/testsuite/gdb.base/many-headers.exp
> >> +++ b/gdb/testsuite/gdb.base/many-headers.exp
> >> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile
> >> $srcfile debug]} {  # Generate core file.
> >>   set corefile [core_find $binfile]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> b/gdb/testsuite/gdb.mi/mi- corefile.exp index
> >> 3f0e7202330..b4914866dfc 100644
> >> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
> >> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile
> >> $srcfile debug] == -1} {
> >>
> >>   set corefile [core_find $binfile {}]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp
> >> b/gdb/testsuite/gdb.threads/corethreads.exp
> >> index 3b50ae3a3cd..0011dc3547c 100644
> >> --- a/gdb/testsuite/gdb.threads/corethreads.exp
> >> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
> >> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads
> >> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
> >>
> >>   set corefile [core_find $binfile]
> >>   if {$corefile == ""} {
> >> +    untested "unable to create or find corefile"
> >>       return 0
> >>   }
> >>
> >> --
> >> 2.43.0
> >
> > I have been a bit too quick here :/, I meant untested instead of
> unsupported in the commit message.
> 
> Heh, I should've read the thread until the end, as I had spotted this. :-)
> 
> > Will fix this once we agreed on the right approach.
> 
> Though I was the one suggesting a FAIL would be useful, I don't feel strongly
> about it. Let's go with UNTESTED and then we can standardize it that way
> across the board.
> 
> Your patch is OK with the unsupported/untested fixed.
> 
> Approved-By: Luis Machado <luis.machado.foss@gmail.com>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928