From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6ZvnMvXXmWiZ0gkAWB0awg (envelope-from ) for ; Mon, 11 Aug 2025 07:45:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WjNKeGMy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C16F21E10A; Mon, 11 Aug 2025 07:45:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56E261E097 for ; Mon, 11 Aug 2025 07:45:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF8363858D35 for ; Mon, 11 Aug 2025 11:45:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF8363858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WjNKeGMy Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by sourceware.org (Postfix) with ESMTPS id 6CBFA3858D21 for ; Mon, 11 Aug 2025 11:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CBFA3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CBFA3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754912676; cv=none; b=hPpA/b78P4ar6d3uMevs5jxkVgRPrAb/9onygByrQudzF320fZ4jOGL8ITqbvRypEH5ZdS5cZ+ivWxFb5bjbNL7kItdEE/GfpshIuFyafMREgcze29xeIvuQuY05QNZrpXiOViPkncSX4a0O7wKA3TN80lrE3ziIsjCbXCmx5LY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754912676; c=relaxed/simple; bh=ikjeclpL/HLskQGagljrKBfWr9c39Mbru6tL05s0sHQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JuJA6sRC9+eWgfSDYLjtTuXWiUHRBABIh8ej47bfGlX/u04/BkC0Sb556RKjWLcLSQG3/LdbUfMX4znG8dZFrSQIKsMgDowgV3jMnfx04701hnJyuyFrUfbR30/wKXUekBX1juI+ZgWcMgOmYlYPxEUCYn6gkeAyXUkTwBwtEtM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CBFA3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754912676; x=1786448676; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ikjeclpL/HLskQGagljrKBfWr9c39Mbru6tL05s0sHQ=; b=WjNKeGMy+JbdCj6jlzk2sjpThqZkQInLFtT90FnYU6kuq8X3h7Bqys9s DW7nVG3k1x+twE7GFdgA8D2LGd18VmkCj+dGOX8Pyq/Utml2gtsQB5dzH bY7lXwzqtUqYTZD8e+fZb4pCvptOfkT0reH9F4F6F23R/cVDVgKxAVW4C iY63fVyyArHNe7R+Mk6GRIPZ/IGfUvRt5BAi7b/K9PshVrbRI33B3WP2h 3I4GaZMPTdOqCX5bEyclElL1D0WQEBNmVMEiPR//GCGWFF0d0AfR7uC2N Cqq3Vwivp34YtOWK/Js8JAOP8rxQD1rt0RxzEshCZNfJeB/Izth5tN5e1 Q==; X-CSE-ConnectionGUID: /hK6E5PIQFC/TasloQVImw== X-CSE-MsgGUID: zof4wlneTGmdfXqIDgVvDQ== X-IronPort-AV: E=McAfee;i="6800,10657,11518"; a="57242686" X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="57242686" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 04:44:35 -0700 X-CSE-ConnectionGUID: hODABArPRZWC3956X3zNDg== X-CSE-MsgGUID: WDMU5LhbQx+SO9H1yx0Qiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="170116226" Received: from 0007e934a912.jf.intel.com (HELO localhost) ([10.165.58.208]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 04:44:35 -0700 From: Christina Schimpe To: gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, luis.machado.foss@gmail.com Subject: [RFC] [PATCH 0/1] Add untested for corefile tests Date: Mon, 11 Aug 2025 04:44:20 -0700 Message-ID: <20250811114421.1311222-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a patch to add UNTESTED for corefile tests in case an OS corefile is not found or is not created. The discussion came up in this thread: https://sourceware.org/pipermail/gdb-patches/2025-August/219807.html and there are mixed opinions how we should treat this. In my opinion, UNTESTED means that there is something wrong with the setup and one should investigate, while UNSUPPORTED means it's acceptable for the test to be skipped. However, I also understand Luis' feedback to add a FAIL, since this strongly indicates that there is something we should look into. However, if we test a patch and only check the new failures introduced by the commit, there is a risk that someone might not realize he is not testing core files at all. We also have a wiki entry for this topic: https://sourceware.org/gdb/wiki/TestingGDB But it's also not completely clear on this specific question: "GDB testsuite expects that corefile will be generated on the same folder of the binary used on the test, when Apport is enabled, it can result in a FAIL/UNTESTED since Apport collects the corefile generated and corefind function in GDB testsuite is unable to find it". In any case I think we should make this consistent in our testsuite and I am looking forward to your feedback. Christina Christina Schimpe (1): testsuite: add unsupported in case OS corefile is not found gdb/testsuite/gdb.base/corefile.exp | 1 + gdb/testsuite/gdb.base/corefile2.exp | 1 + gdb/testsuite/gdb.base/corefile3.exp | 1 + gdb/testsuite/gdb.base/many-headers.exp | 1 + gdb/testsuite/gdb.mi/mi-corefile.exp | 1 + gdb/testsuite/gdb.threads/corethreads.exp | 1 + 6 files changed, 6 insertions(+) -- 2.43.0