From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QYEKCR+vo2izmQYAWB0awg (envelope-from ) for ; Mon, 18 Aug 2025 18:54:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=N9bMHDg+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 136051E048; Mon, 18 Aug 2025 18:54:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 72C591E048 for ; Mon, 18 Aug 2025 18:54:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D725E3857BAF for ; Mon, 18 Aug 2025 22:54:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D725E3857BAF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=N9bMHDg+ Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 73DDB3857B8F for ; Mon, 18 Aug 2025 22:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73DDB3857B8F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73DDB3857B8F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755557629; cv=none; b=kPOUOugm83idjNtwq8lu6i3BnWn2IaPyHzm6Lshc8q+HFlK3g3uhffdAtJ8e1RZmWAJuBD5rxXUA8zeKt8KB6jEm5PcCAKSMja4CcUGZ/P2T2kFLzsRT6bK9aBf4V3VMba/GNJMdKnWLFunvjn+PzpMvN3ye82N3hiEW3W23Ic4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755557629; c=relaxed/simple; bh=2/Piccy1nwANjjKbzHAf4cD16P26rf083bALbl72Jb0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LE3BiullWLgDAwRWUnx3/HLuUwE9ub2eToCZkaQAR9vkXarR4NPO+/nOp263g1zYS6H5pO2Dj8sO4z2SXDcwJNd6l4uGZv5jhmttHCUOyljTC6zRHZgMIlVvdcyninwTVKDlRJul5mjbBachkmgJIBVCDwURLtDyyL6Y8IWY1po= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73DDB3857B8F Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-45a1b0d231eso26191195e9.3 for ; Mon, 18 Aug 2025 15:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755557628; x=1756162428; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=70FMh7nPYXjxzXpiXpM/fkNzvLduk1qTnqSOV6oTCqk=; b=N9bMHDg+Khi00UFMG2keewxqmD/adz1fMA7I9CE2d3HryWjki41DJfaopeyILYRVqw eTJGmL213xDpMFdh9MY0bhzUTAitKgo5ZFCHQrlRnB3yP4G6ee0LMZu9lFGBu7Qqr6mn ThFrxAlUqKRBoadhiND+tPhuXirsjn5OtNgiA5pbABDFlGV91R/aIMgGFOgX4FUiOT7w PjTYOYbkXoaY67kOpO3SjG1gTfrPwf4gyYCQZHGkfXda2JoZ1sMlpIWYNqFxnCgMw5wn Gkm+nVs7AdvTTHmuOyqcpBoTyXoz/78jpBZW+H76JqAb4Ng9v5AkaUiBRvvD9Ouowy/n IcDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755557628; x=1756162428; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=70FMh7nPYXjxzXpiXpM/fkNzvLduk1qTnqSOV6oTCqk=; b=Jdt9jNvFdl8mtmyZJ9MyrbL8vltzJvlp8Gz44vRGjnaw90QGwu5R7XLuFNDYlC9bgL evhZS8UeiXl1RvKO/WBNk/Ozc3OYqc/ALLj5WWlM0rqdijCmXtpJU7PLm8XTXPfaJtc3 BxSn6z48LRMUv5MsaEHuYLYXI3TbLwyKkG5VKoExRMM2paidrFqUoAzublLLQgpWhtEJ mGAuwOJimThLsMwZHW9sxiK1q6HiFVQb80h0ur1qzpWnouLUkTkr7NxR52oJsH1rksQ0 uS4U4YIKt/PZZz/+9f8sZoYLVXS1t0aEvYZ8sLgQNk9JTeADEcLvnLT42yAL57A4DtVv BSjw== X-Forwarded-Encrypted: i=1; AJvYcCUgZD1hyv9fzIYCOn/Lcb7i0RNCoHiXjXzkkLkk5vmqeQfmijrg3LlZhm53u5p5mkZoaPeLCoqOe85DvA==@sourceware.org X-Gm-Message-State: AOJu0YyHNQ4w+8q2qsL1L5UQozBrGWLzRbSIrmxLux5CS01Boc4U4Uyz yhVJPxnApN/kjkPENmKsl+uhFqTNFT3UoFsFFdLZxrNny3gI2DHJxPFS X-Gm-Gg: ASbGncsvxsAAyhN0HUJ1pvoryedtWJ/ffbdDGXwe07mALOsi+9peLRYt2AsjsFJWvLz 5MBEiBWKG0MXaxgwvjW2Cy+RMMtiieqI31/TSLm/cv1k4TRPCI3EuU8jKX9w6RrfpoJkdlxPtu2 L6RJ/WNuxyFHbWbRlcuZ+YovtHI5M4GAitFIKA0Xnm0oq3L13rqHGUSCWMaae53ES8SV7Gz1shb +Jq84YXyDtIBn406epTxnjYSCxt8rv00UOx2tokIUk6VnvnYI0iczKQNurF0u351fQsgsaCXcPI 73YIm3CODg3/1U3QGf2pPn19HzbmsXvMgBfzarZt4Ta0PU/sB62p51RbBPyXl2XeXxQX52675to nZdbezhHscMpXkQB9jcnKvax8gl2JcNnbBKQ= X-Google-Smtp-Source: AGHT+IHF47miV5ATyvbwYzyL4Ck6jcmawlyoOLUxSYiwC0U5hidvAsalmzwUmajNO5bPqenWRxr0Ug== X-Received: by 2002:a05:600c:1f94:b0:458:bc3f:6a72 with SMTP id 5b1f17b1804b1-45b43db7004mr2164935e9.4.1755557628078; Mon, 18 Aug 2025 15:53:48 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c0771c1715sm1168284f8f.36.2025.08.18.15.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 15:53:47 -0700 (PDT) Message-ID: <0ede1e9e-50a0-4c29-8cba-3d9a4e2e3f3b@gmail.com> Date: Mon, 18 Aug 2025 23:53:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found To: Christina Schimpe , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20250811114421.1311222-1-christina.schimpe@intel.com> <20250811114421.1311222-2-christina.schimpe@intel.com> Content-Language: en-US From: Luis In-Reply-To: <20250811114421.1311222-2-christina.schimpe@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Christina, On 8/11/25 12:44, Christina Schimpe wrote: > Even though the core_find proc will log a warning, it's better to log > "unsupported" and then terminate the test. This will help to avoid Did you mean untested here instead of unsupported, based on the code below? > silently skipped tests, when running the testsuite. Most of the tests > already do that. This patch adds the missing ones. > --- > gdb/testsuite/gdb.base/corefile.exp | 1 + > gdb/testsuite/gdb.base/corefile2.exp | 1 + > gdb/testsuite/gdb.base/corefile3.exp | 1 + > gdb/testsuite/gdb.base/many-headers.exp | 1 + > gdb/testsuite/gdb.mi/mi-corefile.exp | 1 + > gdb/testsuite/gdb.threads/corethreads.exp | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp > index da1fdf3517c..fd8d1d1274c 100644 > --- a/gdb/testsuite/gdb.base/corefile.exp > +++ b/gdb/testsuite/gdb.base/corefile.exp > @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { > # mmapped data in core file" test. > set corefile [core_find $binfile {}] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return 0 > } > > diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp > index 392705b5930..d35ba1a1295 100644 > --- a/gdb/testsuite/gdb.base/corefile2.exp > +++ b/gdb/testsuite/gdb.base/corefile2.exp > @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { > > set corefile [core_find $binfile {}] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return 0 > } > > diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp > index 57b230004b6..ef391d15049 100644 > --- a/gdb/testsuite/gdb.base/corefile3.exp > +++ b/gdb/testsuite/gdb.base/corefile3.exp > @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} { > > set corefile [core_find $binfile {}] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return > } > > diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp > index f46b9800cf9..5e022da8534 100644 > --- a/gdb/testsuite/gdb.base/many-headers.exp > +++ b/gdb/testsuite/gdb.base/many-headers.exp > @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} { > # Generate core file. > set corefile [core_find $binfile] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return 0 > } > > diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp > index 3f0e7202330..b4914866dfc 100644 > --- a/gdb/testsuite/gdb.mi/mi-corefile.exp > +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp > @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { > > set corefile [core_find $binfile {}] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return 0 > } > > diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp > index 3b50ae3a3cd..0011dc3547c 100644 > --- a/gdb/testsuite/gdb.threads/corethreads.exp > +++ b/gdb/testsuite/gdb.threads/corethreads.exp > @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa > > set corefile [core_find $binfile] > if {$corefile == ""} { > + untested "unable to create or find corefile" > return 0 > } >