Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christina Schimpe <christina.schimpe@intel.com>
To: gdb-patches@sourceware.org
Cc: thiago.bauermann@linaro.org, luis.machado.foss@gmail.com
Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found
Date: Mon, 11 Aug 2025 04:44:21 -0700	[thread overview]
Message-ID: <20250811114421.1311222-2-christina.schimpe@intel.com> (raw)
In-Reply-To: <20250811114421.1311222-1-christina.schimpe@intel.com>

Even though the core_find proc will log a warning, it's better to log
"unsupported" and then terminate the test.  This will help to avoid
silently skipped tests, when running the testsuite.  Most of the tests
already do that.  This patch adds the missing ones.
---
 gdb/testsuite/gdb.base/corefile.exp       | 1 +
 gdb/testsuite/gdb.base/corefile2.exp      | 1 +
 gdb/testsuite/gdb.base/corefile3.exp      | 1 +
 gdb/testsuite/gdb.base/many-headers.exp   | 1 +
 gdb/testsuite/gdb.mi/mi-corefile.exp      | 1 +
 gdb/testsuite/gdb.threads/corethreads.exp | 1 +
 6 files changed, 6 insertions(+)

diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
index da1fdf3517c..fd8d1d1274c 100644
--- a/gdb/testsuite/gdb.base/corefile.exp
+++ b/gdb/testsuite/gdb.base/corefile.exp
@@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 # mmapped data in core file" test.
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp
index 392705b5930..d35ba1a1295 100644
--- a/gdb/testsuite/gdb.base/corefile2.exp
+++ b/gdb/testsuite/gdb.base/corefile2.exp
@@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp
index 57b230004b6..ef391d15049 100644
--- a/gdb/testsuite/gdb.base/corefile3.exp
+++ b/gdb/testsuite/gdb.base/corefile3.exp
@@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return
 }
 
diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp
index f46b9800cf9..5e022da8534 100644
--- a/gdb/testsuite/gdb.base/many-headers.exp
+++ b/gdb/testsuite/gdb.base/many-headers.exp
@@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
 # Generate core file.
 set corefile [core_find $binfile]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp
index 3f0e7202330..b4914866dfc 100644
--- a/gdb/testsuite/gdb.mi/mi-corefile.exp
+++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
@@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
 
 set corefile [core_find $binfile {}]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp
index 3b50ae3a3cd..0011dc3547c 100644
--- a/gdb/testsuite/gdb.threads/corethreads.exp
+++ b/gdb/testsuite/gdb.threads/corethreads.exp
@@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
 
 set corefile [core_find $binfile]
 if {$corefile == ""} {
+    untested "unable to create or find corefile"
     return 0
 }
 
-- 
2.43.0


  reply	other threads:[~2025-08-11 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 11:44 [RFC] [PATCH 0/1] Add untested for corefile tests Christina Schimpe
2025-08-11 11:44 ` Christina Schimpe [this message]
2025-08-11 11:48   ` [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found Schimpe, Christina
2025-08-18 23:00     ` Luis
2025-08-20 19:12       ` Schimpe, Christina
2025-08-28 16:01       ` Schimpe, Christina
2025-08-18 22:53   ` Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811114421.1311222-2-christina.schimpe@intel.com \
    --to=christina.schimpe@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox