From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SAhUKRrYmWiZ0gkAWB0awg (envelope-from ) for ; Mon, 11 Aug 2025 07:46:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OPjErrW1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A60121E10A; Mon, 11 Aug 2025 07:46:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 386411E097 for ; Mon, 11 Aug 2025 07:46:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9FA23858CB6 for ; Mon, 11 Aug 2025 11:46:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9FA23858CB6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OPjErrW1 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by sourceware.org (Postfix) with ESMTPS id BD28C3858C74 for ; Mon, 11 Aug 2025 11:44:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD28C3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD28C3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754912683; cv=none; b=giBYWBD5f/sYgK8q2gS2EYaotZTZD8F+VAo/4wX29UNl5iPeDjt3p6S/cKJSp8I2JLtViR/wwkYJ9Cc1PP7OnJA6yXgmIOWy+JrslepW6jTPPUTYT9AQRybDvGJk1xWQFyCNwJsE3P4jWwhXfb4BfIi9AphK0Wzxs6gx8OITdsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754912683; c=relaxed/simple; bh=j/TwWc2XgxxG7nplbEW9Bn1OXkIU1pvA0pwp8nfNOKM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hia1FfS8K1AXflyAj0em/+8+lHXJdZCCSmM8OTTRHkOqQLGaOZU6csbpOY/JREHkPhqgK+Co2ENY62Al8dtbmesixG7yeOz4RpRPit4ijdMCLkbu8KnHMN2hz3RaXoBxn1t3sOeRQ61BFDK+oQXOuX6/a8wqiF0YyNoI2GNWwJA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD28C3858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754912683; x=1786448683; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j/TwWc2XgxxG7nplbEW9Bn1OXkIU1pvA0pwp8nfNOKM=; b=OPjErrW1soNfBXAfMXYAZfX31lcVOx8WEuk2Fjc0bsgX+piwclFiGQ7Q 0RzEvYxYmlRWGWoVWiEcJWTR6jxXVbih7zcAYyUXEENBzu9K7qe4Lynu1 ivs9lmqL2qtM4ZWWu3KkoyyQK26MHzQSJGCW6FM5MGcK6MoTlRUO23QnE lAwngkOfFjVg8RerC9CKttet7JtVbtxOnXr2U5k+69NsVgxaKZb+bHiSt 2pVFAF1xRuF04Hu9a85Ea+YB5QBLLZUw/0SHakydRCPsy5D25lR+gDCjg sBYGz3V8d/2GXAjfKzwgzYmRcUYcERByeemvq1sisI42Gic5zVXw6dna4 w==; X-CSE-ConnectionGUID: /td3hKE2T8CWaZaOs4ejYA== X-CSE-MsgGUID: /MJieY8OQWOqfansm+lsZw== X-IronPort-AV: E=McAfee;i="6800,10657,11518"; a="56875320" X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="56875320" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 04:44:42 -0700 X-CSE-ConnectionGUID: 4qFnSAFWTMeBzfsoiDEdDg== X-CSE-MsgGUID: 99csJFF3RbmZEA4rNuXw/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="170334586" Received: from 0007e934a912.jf.intel.com (HELO localhost) ([10.165.58.208]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 04:44:42 -0700 From: Christina Schimpe To: gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, luis.machado.foss@gmail.com Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found Date: Mon, 11 Aug 2025 04:44:21 -0700 Message-ID: <20250811114421.1311222-2-christina.schimpe@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250811114421.1311222-1-christina.schimpe@intel.com> References: <20250811114421.1311222-1-christina.schimpe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Even though the core_find proc will log a warning, it's better to log "unsupported" and then terminate the test. This will help to avoid silently skipped tests, when running the testsuite. Most of the tests already do that. This patch adds the missing ones. --- gdb/testsuite/gdb.base/corefile.exp | 1 + gdb/testsuite/gdb.base/corefile2.exp | 1 + gdb/testsuite/gdb.base/corefile3.exp | 1 + gdb/testsuite/gdb.base/many-headers.exp | 1 + gdb/testsuite/gdb.mi/mi-corefile.exp | 1 + gdb/testsuite/gdb.threads/corethreads.exp | 1 + 6 files changed, 6 insertions(+) diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp index da1fdf3517c..fd8d1d1274c 100644 --- a/gdb/testsuite/gdb.base/corefile.exp +++ b/gdb/testsuite/gdb.base/corefile.exp @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { # mmapped data in core file" test. set corefile [core_find $binfile {}] if {$corefile == ""} { + untested "unable to create or find corefile" return 0 } diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp index 392705b5930..d35ba1a1295 100644 --- a/gdb/testsuite/gdb.base/corefile2.exp +++ b/gdb/testsuite/gdb.base/corefile2.exp @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { set corefile [core_find $binfile {}] if {$corefile == ""} { + untested "unable to create or find corefile" return 0 } diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp index 57b230004b6..ef391d15049 100644 --- a/gdb/testsuite/gdb.base/corefile3.exp +++ b/gdb/testsuite/gdb.base/corefile3.exp @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} { set corefile [core_find $binfile {}] if {$corefile == ""} { + untested "unable to create or find corefile" return } diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp index f46b9800cf9..5e022da8534 100644 --- a/gdb/testsuite/gdb.base/many-headers.exp +++ b/gdb/testsuite/gdb.base/many-headers.exp @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} { # Generate core file. set corefile [core_find $binfile] if {$corefile == ""} { + untested "unable to create or find corefile" return 0 } diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp index 3f0e7202330..b4914866dfc 100644 --- a/gdb/testsuite/gdb.mi/mi-corefile.exp +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { set corefile [core_find $binfile {}] if {$corefile == ""} { + untested "unable to create or find corefile" return 0 } diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp index 3b50ae3a3cd..0011dc3547c 100644 --- a/gdb/testsuite/gdb.threads/corethreads.exp +++ b/gdb/testsuite/gdb.threads/corethreads.exp @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa set corefile [core_find $binfile] if {$corefile == ""} { + untested "unable to create or find corefile" return 0 } -- 2.43.0