From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yL21NrCwo2h4mgYAWB0awg (envelope-from ) for ; Mon, 18 Aug 2025 19:01:04 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ezCo4f+a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CB3E61E0B3; Mon, 18 Aug 2025 19:01:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F4BF1E048 for ; Mon, 18 Aug 2025 19:01:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BF1423857BAF for ; Mon, 18 Aug 2025 23:01:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF1423857BAF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ezCo4f+a Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 6330C3857B8F for ; Mon, 18 Aug 2025 23:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6330C3857B8F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6330C3857B8F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755558032; cv=none; b=C6k96SB0URjtVrGdzZDiDNqjTGUPteN4pB3B4Zdq5n0Vqd2XgEys6F3QSYbZR2j4ME3AAtJwMwv//GGiGNz56Z9e/99kxTXa0T5N17983mCBKgHLJGN8FHYA5vJOsXJjblr+p1uFOlorSKNGZf2DcaYGBSS2le55oa2dYgUnLnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755558032; c=relaxed/simple; bh=rFcGUuB0oWU9XaKJeRqeSadGHFmn3yRaiGbFjamHecA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iJeCdAg7V3ZDwnbEuDTOnhTiNM6ZbWspgqWS4ZyeAtROxt+3aUMzfjWc72v2touwYKtmXftX+0+WuCK7AuEk3NChqbNK3uw7bSYxtximF4M+AZ5sdgcgb67rv8vsVC6fQC83ho9MO4FKV+tq9YD2f0qr1LBpcaecHSLDCynWQAQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6330C3857B8F Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3b9e4106460so3757728f8f.2 for ; Mon, 18 Aug 2025 16:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755558031; x=1756162831; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+XbZU5sum04GqnhbO+EEuZ0ydXjC1J7hWGjxVOfDVfo=; b=ezCo4f+aj40FrZaVqFE6V+xFJrCutP3cwUkKCZgHppUKbJ+wH+tcYL17bk/iB7W3aW pX/bu3EizpiEXH5UfM9MdoAbfjgg5VpCqKgumXSz4i9tDGhXggbsLqMeQpxcBvN6KlbV pH1vMSZreNwefX01lQ/j1N6G8gDj+Rkyf7Tzu8QoCc26R7h0jGoo11hh7XqJL/wmo2N6 Uv+Ti3M29kV97/deYXfGQCapGVHWuMk989yLeI1H3EevOq3iWQ0feB/D4GODnVGJ33Au /esJwUxwtaTU42g8qk5OMZ88WNcIaxqQtfs7MxLbJikxG0WCCwNcc5xB3mwzbiXeeUUW e2Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755558031; x=1756162831; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+XbZU5sum04GqnhbO+EEuZ0ydXjC1J7hWGjxVOfDVfo=; b=pxYeBga6r/9SGtuOB+NcmZcVQ49sayOeFnY9q+TkVWiKxYJrgRIbSHvqKxsbCF8pGS F7x0N3q1uTFZ06GM96GOOLN7Ghzk+pnzqLdLlFmTVX7CTrIilBGs/GHaGldyFIaGUhqi jTJLnv+QOeePG906gvO6K8SnqbcHpDQyq4rKNDU41t76WUPYcYyd3MEzON+IzKztL7GJ hX/MXy1bZJSN1XRYJlBANgKuddthrzLpcIyOXQk2BmhpY6mxtVPYpQLPdf+NZOq/EbNz h6uDYFiaDgZf173vgxGcRy9AWF1e09TJ/Ud3c7P/aGopT7KGpQWtAOmzkW3xdhi+mOIr zURA== X-Forwarded-Encrypted: i=1; AJvYcCVXBGllKAWuch81wKrnAgXETygTEUyavTEWF5x59P7wTDKOsChGYm69HaSMgDoThX9F+Gb0S0QgJKxSug==@sourceware.org X-Gm-Message-State: AOJu0YwaHxPaIrEuKjyJbKTLTNhJ0B1VKLvUzZHJW0oeOHYSRlobfksY 8O16kX7FLBal/jN2VQA1RcspDX1GVxrWxbkyHcz2HaE+zvMLfOrbKn5R X-Gm-Gg: ASbGncuePb7hq5dUGCrUDQKNaPEU6sRfRlVECIewx1Hg0unY/FpS8lj0xpAqNKZQd92 hu/9VymUqbH6ch5L7gmfz7oK7+gBzonkyVsKAmbTS1Rp5ksUy/1PSkEq0/FNzqVaf3IztV0vTnX GLnztizxnzS0gqNsrfHBWDDt0p77r4EzgjIkuSkWcDz0PVJnIh3xjvX8h15u9COrBdtR06QKLBA gGjof56RkxPuScpMuR3nzOZ2XVnEctvO/oMs3RYYF+zu14XEzC87vNZj/tDhAEH4T/D3Qsx+qNd 7Gz3j2K9OJ90syPkmKNaK4Bo5ArkQVp8bRNSJmmRVfF/ob7nLLBCyUvXdUvb7bF8Wxq1Og7b9So Nz0RzssctnkqsijD6w/uvmOhFeIEKJMlIdGlN9RsiDHYbaQ== X-Google-Smtp-Source: AGHT+IGaiV08E9K6vquPFm2S1AGIyTkRdH2me2cYsorCoGUE797LTtEje3yuBTaEVy/QSwYlU1Dcmw== X-Received: by 2002:a05:6000:250f:b0:3b8:d139:5357 with SMTP id ffacd0b85a97d-3c0ecc322abmr305847f8f.31.1755558030950; Mon, 18 Aug 2025 16:00:30 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c074879fe5sm1164296f8f.2.2025.08.18.16.00.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 16:00:30 -0700 (PDT) Message-ID: <3ed718ba-c56b-4041-bc1f-89b9b8ff7487@gmail.com> Date: Tue, 19 Aug 2025 00:00:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" References: <20250811114421.1311222-1-christina.schimpe@intel.com> <20250811114421.1311222-2-christina.schimpe@intel.com> Content-Language: en-US From: Luis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/11/25 12:48, Schimpe, Christina wrote: >> -----Original Message----- >> From: Christina Schimpe >> Sent: Monday, August 11, 2025 1:44 PM >> To: gdb-patches@sourceware.org >> Cc: thiago.bauermann@linaro.org; luis.machado.foss@gmail.com >> Subject: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not >> found >> >> Even though the core_find proc will log a warning, it's better to log >> "unsupported" and then terminate the test. This will help to avoid silently >> skipped tests, when running the testsuite. Most of the tests already do >> that. This patch adds the missing ones. >> --- >> gdb/testsuite/gdb.base/corefile.exp | 1 + >> gdb/testsuite/gdb.base/corefile2.exp | 1 + >> gdb/testsuite/gdb.base/corefile3.exp | 1 + >> gdb/testsuite/gdb.base/many-headers.exp | 1 + >> gdb/testsuite/gdb.mi/mi-corefile.exp | 1 + >> gdb/testsuite/gdb.threads/corethreads.exp | 1 + >> 6 files changed, 6 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.base/corefile.exp >> b/gdb/testsuite/gdb.base/corefile.exp >> index da1fdf3517c..fd8d1d1274c 100644 >> --- a/gdb/testsuite/gdb.base/corefile.exp >> +++ b/gdb/testsuite/gdb.base/corefile.exp >> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile >> debug] == -1} { # mmapped data in core file" test. >> set corefile [core_find $binfile {}] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return 0 >> } >> >> diff --git a/gdb/testsuite/gdb.base/corefile2.exp >> b/gdb/testsuite/gdb.base/corefile2.exp >> index 392705b5930..d35ba1a1295 100644 >> --- a/gdb/testsuite/gdb.base/corefile2.exp >> +++ b/gdb/testsuite/gdb.base/corefile2.exp >> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile >> debug] == -1} { >> >> set corefile [core_find $binfile {}] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return 0 >> } >> >> diff --git a/gdb/testsuite/gdb.base/corefile3.exp >> b/gdb/testsuite/gdb.base/corefile3.exp >> index 57b230004b6..ef391d15049 100644 >> --- a/gdb/testsuite/gdb.base/corefile3.exp >> +++ b/gdb/testsuite/gdb.base/corefile3.exp >> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == - >> 1} { >> >> set corefile [core_find $binfile {}] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return >> } >> >> diff --git a/gdb/testsuite/gdb.base/many-headers.exp >> b/gdb/testsuite/gdb.base/many-headers.exp >> index f46b9800cf9..5e022da8534 100644 >> --- a/gdb/testsuite/gdb.base/many-headers.exp >> +++ b/gdb/testsuite/gdb.base/many-headers.exp >> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile >> $srcfile debug]} { # Generate core file. >> set corefile [core_find $binfile] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return 0 >> } >> >> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi- >> corefile.exp >> index 3f0e7202330..b4914866dfc 100644 >> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp >> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp >> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile >> debug] == -1} { >> >> set corefile [core_find $binfile {}] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return 0 >> } >> >> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp >> b/gdb/testsuite/gdb.threads/corethreads.exp >> index 3b50ae3a3cd..0011dc3547c 100644 >> --- a/gdb/testsuite/gdb.threads/corethreads.exp >> +++ b/gdb/testsuite/gdb.threads/corethreads.exp >> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads >> "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa >> >> set corefile [core_find $binfile] >> if {$corefile == ""} { >> + untested "unable to create or find corefile" >> return 0 >> } >> >> -- >> 2.43.0 > > I have been a bit too quick here :/, I meant untested instead of unsupported in the commit message. Heh, I should've read the thread until the end, as I had spotted this. :-) > Will fix this once we agreed on the right approach. Though I was the one suggesting a FAIL would be useful, I don't feel strongly about it. Let's go with UNTESTED and then we can standardize it that way across the board. Your patch is OK with the unsupported/untested fixed. Approved-By: Luis Machado