From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
gdb-patches@sourceware.org
Subject: Re: GDB/Fortran: Support for Assumed Rank Zero.
Date: Mon, 18 Apr 2022 08:33:28 -0700 [thread overview]
Message-ID: <20220418083328.5fb70540@f35-zws-1> (raw)
In-Reply-To: <DM6PR12MB42193AD60807B3C11A208306E7F19@DM6PR12MB4219.namprd12.prod.outlook.com>
On Sat, 16 Apr 2022 18:29:46 +0000
"Potharla, Rupesh" <Rupesh.Potharla@amd.com> wrote:
> diff --git a/gdb/testsuite/gdb.fortran/assumedrank.exp b/gdb/testsuite/gdb.fortran/assumedrank.exp
> index 69cd168125f..bd058e01e89 100644
> --- a/gdb/testsuite/gdb.fortran/assumedrank.exp
> +++ b/gdb/testsuite/gdb.fortran/assumedrank.exp
> @@ -58,6 +58,13 @@ while { $test_count < 500 } {
> }
> }
>
> + # XFAIL rank 0 for flang.
> + if {$test_count == 1 && [test_compiler_info {clang-*}]} {
> + setup_xfail "*-*-*"
> + fail "compiler does not support rank 0"
> + continue
> + }
> +
> if ($found_final_breakpoint) {
> break
> }
>
Now that you're using setup_xfail, this should be moved into the loop
above. Also, you should remove the fail and the continue. You'll
want to use setup_xfail just before running the test for which you want
to turn a possible FAIL into an XFAIL.
I'm also (still) wondering how to run the testsuite to use flang
instead of gfortran since it'd be nice to test to see if the setup_xfail
actually works. I spent just enough time looking at it last week
to convince myself that GDB's testing infrastructure currently lacks the
mechanisms to do this. However, I could be wrong, so if someone
knows how it's done, I'd like to learn about it...
Kevin
next prev parent reply other threads:[~2022-04-18 15:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:55 Potharla, Rupesh via Gdb-patches
2022-04-13 18:27 ` Kevin Buettner via Gdb-patches
2022-04-14 10:30 ` Potharla, Rupesh via Gdb-patches
2022-04-14 21:28 ` Kevin Buettner via Gdb-patches
2022-04-15 13:33 ` Potharla, Rupesh via Gdb-patches
2022-04-15 19:31 ` Kevin Buettner via Gdb-patches
2022-04-16 18:29 ` Potharla, Rupesh via Gdb-patches
2022-04-18 13:31 ` Tom Tromey
2022-04-18 15:25 ` Potharla, Rupesh via Gdb-patches
2022-04-20 15:22 ` Andrew Burgess via Gdb-patches
2022-04-20 19:08 ` Potharla, Rupesh via Gdb-patches
2022-04-22 14:38 ` Andrew Burgess via Gdb-patches
2022-04-25 6:33 ` Potharla, Rupesh via Gdb-patches
2022-04-25 8:47 ` Andrew Burgess via Gdb-patches
2022-04-18 15:33 ` Kevin Buettner via Gdb-patches [this message]
2022-04-19 17:30 ` Kevin Buettner via Gdb-patches
2022-04-20 0:29 ` Potharla, Rupesh via Gdb-patches
2022-04-20 6:32 ` Kempke, Nils-Christian via Gdb-patches
2022-04-20 15:38 ` Kevin Buettner via Gdb-patches
2022-04-20 15:29 ` Andrew Burgess via Gdb-patches
2022-04-20 19:20 ` Potharla, Rupesh via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418083328.5fb70540@f35-zws-1 \
--to=gdb-patches@sourceware.org \
--cc=AlokKumar.Sharma@amd.com \
--cc=Hariharan.Parasuraman@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Rupesh.Potharla@amd.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox