Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Kempke, Nils-Christian via Gdb-patches" <gdb-patches@sourceware.org>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>,
	Kevin Buettner <kevinb@redhat.com>,
	Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
	"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
	"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>
Subject: RE: GDB/Fortran: Support for Assumed Rank Zero.
Date: Wed, 20 Apr 2022 06:32:25 +0000	[thread overview]
Message-ID: <CY4PR1101MB2071BBFECC39AA152CE69F58B8F59@CY4PR1101MB2071.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR12MB42193E343DBABB62F87E800FE7F59@DM6PR12MB4219.namprd12.prod.outlook.com>



> -----Original Message-----
> From: Gdb-patches <gdb-patches-bounces+nils-
> christian.kempke=intel.com@sourceware.org> On Behalf Of Potharla,
> Rupesh via Gdb-patches
> Sent: Wednesday, April 20, 2022 2:29 AM
> To: Kevin Buettner <kevinb@redhat.com>; Kevin Buettner via Gdb-patches
> <gdb-patches@sourceware.org>
> Cc: George, Jini Susan <JiniSusan.George@amd.com>; Parasuraman,
> Hariharan <Hariharan.Parasuraman@amd.com>; Sharma, Alok Kumar
> <AlokKumar.Sharma@amd.com>
> Subject: RE: GDB/Fortran: Support for Assumed Rank Zero.
> 
> [AMD Official Use Only]
> 
> 
> >On Mon, 18 Apr 2022 08:33:28 -0700
> >Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org> wrote:
> >
> >> I'm also (still) wondering how to run the testsuite to use flang
> >> instead of gfortran since it'd be nice to test to see if the
> >> setup_xfail actually works.  I spent just enough time looking at it
> >> last week to convince myself that GDB's testing infrastructure
> >> currently lacks the mechanisms to do this.  However, I could be wrong,
> >> so if someone knows how it's done, I'd like to learn about it...
> >
> >It seems that the answer is to run the test as follows:
> >
> >make check TESTS="gdb.fortran/assumedrank.exp"
> >RUNTESTFLAGS="F90_FOR_TARGET=flang"
> >
> >(I thought that I had tried this last week.)
> >
> >When I run the above command on my Fedora 35 machine, I see:
> >
> ># of expected passes            500
> ># of unexpected failures        2503
> ># of unresolved testcases       500
> >
> But the command should only run assumedrank.exp testcase, looks like it ran
> all the tests under gdb.fortran.
> 
> gdb summary after running assumedrank.exp with flang:
> 
>                 === gdb Summary ===
> 
> # of expected passes            25
> # of expected failures          1
> 
> >So it seems that this test doesn't work very well with flang at the moment.
> >
> >That being the case, while I'm not against adding setup_xfail for clang, it
> >doesn't seem all that useful due to the dismal results when testing against
> >flang.
> >
> 
> 
>         if {$test_count == 1 && [test_compiler_info {clang-*}]} {
>            setup_xfail "*-*-*"
>            fail "compiler does not support rank 0"
>            continue
>         }
> 
> I think failing the testcase at the iteration entry and continuing to test next
> case is the best way to handle these dismal results.
> Please let me know your suggestions/comments on this.
> 
> Regards,
> Rupesh P

Please not a problem with this - if one wants to use a Fortran compiler other than
gfortran one always has to also supply the respective c-compiler in order for it to
get recognized properly. This is a shortcoming in the current compiler
identification - I'm actually working on a patch for that.

But running
   make check TESTS="gdb.fortran/assumedrank.exp" RUNTESTFLAGS="F90_FOR_TARGET=flang"
and looking at the log will show that the compiler identification actually identified
gcc and gfortran as the compiler used (it will still try to compile with flang but the identified
compiler in get_/test_compiler_info is gcc..). From my run in gdb.log:

   get_compiler_info: gcc-9-3-0
   UNTESTED: gdb.fortran/assumedrank.exp: compiler does not support assumed rank
   testcase /.../gdb/testsuite/gdb.fortran/assumedrank.exp completed in 0 seconds

                   === gdb Summary ===

   # of untested testcases         1

The correct command would probably be

   make check TESTS="gdb.fortran/assumedrank.exp" RUNTESTFLAGS="F90_FOR_TARGET=flang
      CC_FOR_TARGET=clang"

which leads to output like:

   Running .../testsuite/gdb.fortran/pointers.exp ...
   get_compiler_info: clang-10-0-0

Cheers,
Nils
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2022-04-20  6:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  9:55 Potharla, Rupesh via Gdb-patches
2022-04-13 18:27 ` Kevin Buettner via Gdb-patches
2022-04-14 10:30   ` Potharla, Rupesh via Gdb-patches
2022-04-14 21:28     ` Kevin Buettner via Gdb-patches
2022-04-15 13:33       ` Potharla, Rupesh via Gdb-patches
2022-04-15 19:31         ` Kevin Buettner via Gdb-patches
2022-04-16 18:29           ` Potharla, Rupesh via Gdb-patches
2022-04-18 13:31             ` Tom Tromey
2022-04-18 15:25               ` Potharla, Rupesh via Gdb-patches
2022-04-20 15:22                 ` Andrew Burgess via Gdb-patches
2022-04-20 19:08                   ` Potharla, Rupesh via Gdb-patches
2022-04-22 14:38                     ` Andrew Burgess via Gdb-patches
2022-04-25  6:33                       ` Potharla, Rupesh via Gdb-patches
2022-04-25  8:47                         ` Andrew Burgess via Gdb-patches
2022-04-18 15:33             ` Kevin Buettner via Gdb-patches
2022-04-19 17:30               ` Kevin Buettner via Gdb-patches
2022-04-20  0:29                 ` Potharla, Rupesh via Gdb-patches
2022-04-20  6:32                   ` Kempke, Nils-Christian via Gdb-patches [this message]
2022-04-20 15:38                     ` Kevin Buettner via Gdb-patches
2022-04-20 15:29                   ` Andrew Burgess via Gdb-patches
2022-04-20 19:20                     ` Potharla, Rupesh via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1101MB2071BBFECC39AA152CE69F58B8F59@CY4PR1101MB2071.namprd11.prod.outlook.com \
    --to=gdb-patches@sourceware.org \
    --cc=AlokKumar.Sharma@amd.com \
    --cc=Hariharan.Parasuraman@amd.com \
    --cc=JiniSusan.George@amd.com \
    --cc=Rupesh.Potharla@amd.com \
    --cc=kevinb@redhat.com \
    --cc=nils-christian.kempke@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox