RE: GDB/Fortran: Support for Assumed Rank Zero.

["Potharla, Rupesh via Gdb-patches" <gdb-patches@sourceware.org>]

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

[AMD Official Use Only]

Thanks Kevin, 

Requesting to review the updated patch with suggested changes. TYPE_DYN_PROP is added by me as part of assumed rank feature(e1ac856e3aee2f95e567e5fbca17e41b72957cdb) only for this case. Since we are no longer using it removed the macro. 


Regards,
Rupesh P

> -----Original Message-----
> From: Kevin Buettner <kevinb@redhat.com>
> Sent: Wednesday, April 13, 2022 11:58 PM
> To: Potharla, Rupesh via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Potharla, Rupesh <Rupesh.Potharla@amd.com>; George, Jini Susan
> <JiniSusan.George@amd.com>; Parasuraman, Hariharan
> <Hariharan.Parasuraman@amd.com>; Sharma, Alok Kumar
> <AlokKumar.Sharma@amd.com>
> Subject: Re: GDB/Fortran: Support for Assumed Rank Zero.
> 
> [CAUTION: External Email]
> 
> Hi Rupesh,
> 
> Thanks for working on this problem.  I found a couple of nits; see below.
> 
> On Wed, 13 Apr 2022 09:55:01 +0000
> "Potharla, Rupesh via Gdb-patches" <gdb-patches@sourceware.org> wrote:
> 
> > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index
> > 49ecb199b07..c2d142ac3cc 100644
> > --- a/gdb/gdbtypes.c
> > +++ b/gdb/gdbtypes.c
> > @@ -2398,10 +2398,12 @@ resolve_dynamic_array_or_string (struct type
> > *type,
> >
> >        if (rank == 0)
> >       {
> > -       /* The dynamic property list juggling below was from the original
> > -          patch.  I don't understand what this is all about, so I've
> > -          commented it out for now and added the following error.  */
> > -       error (_("failed to resolve dynamic array rank"));
> > +       /* Rank is zero, if a variable is passed as an argument to a
> > +          function. GDB considers the variable as an array so discard
> > +          the array type and return the target type which is of variable. */
> > +          TYPE_DYN_PROP(TYPE_TARGET_TYPE(type)) =
> TYPE_DYN_PROP(type);
> > +          type = TYPE_TARGET_TYPE(type);
> > +          return type;
> >       }
> >        else if (type->code () == TYPE_CODE_STRING && rank != 1)
> >       {
> >
> 
> GDB's coding standard requires that things like TYPE_TARGET_TYPE(type) be
> written with a space before the left paren, i.e. TYPE_TARGET_TYPE (type).
> 
> See:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> ceware.org%2Fgdb%2Fwiki%2FInternals%2520GDB-C-Coding-
> Standards&amp;data=04%7C01%7Crupesh.potharla%40amd.com%7C4f7745
> 3bd29d4333881d08da1d7b55bf%7C3dd8961fe4884e608e11a82d994e183d%
> 7C0%7C0%7C637854712954812288%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00&amp;sdata=pqbYaZKCkhvCLBDXdq9obe8NJUpFlOWK3nhPCtAWMlY%3D&
> amp;reserved=0
> 
> Also, regarding TYPE_DYN_PROP, it appears to me that this macro is no
> longer being used.  I've noticed that other code in gdbtypes.c is referencing
> the dyn_prop_list field directly.
> 
> Kevin

[-- Attachment #2: 0001-gdb-fortran-Support-for-assumed-rank-zero.patch --]
[-- Type: application/octet-stream, Size: 4160 bytes --]

From e1ac856e3aee2f95e567e5fbca17e41b72957cdb Mon Sep 17 00:00:00 2001
From: rupothar <rupesh.potharla@amd.com>
Date: Fri, 8 Apr 2022 16:05:41 +0530
Subject: [PATCH] gdb/fortran: Support for assumed rank zero

If a variable is passed to function in FORTRAN as an argument the
variable is treated as an array with rank zero. GDB currently does
not support the case for assumed rank 0. This patch provides support
for assumed rank 0 and updates the testcase as well.

Without patch:
Breakpoint 1, arank::sub1 (a=<error reading variable:
  failed to resolve dynamic array rank>) at assumedrank.f90:11
11       PRINT *, RANK(a)
(gdb) p a
failed to resolve dynamic array rank
(gdb) p rank(a)
failed to resolve dynamic array rank

With patch:
Breakpoint 1, arank::sub1 (a=0) at assumedrank.f90:11
11       PRINT *, RANK(a)
(gdb) p a
$1 = 0
(gdb) p rank(a)
$2 = 0
---
 gdb/gdbtypes.c                            | 11 +++++++----
 gdb/gdbtypes.h                            |  1 -
 gdb/testsuite/gdb.fortran/assumedrank.exp |  7 +++++++
 gdb/testsuite/gdb.fortran/assumedrank.f90 |  3 +++
 4 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 49ecb199b07..21db5aafc88 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -2398,10 +2398,13 @@ resolve_dynamic_array_or_string (struct type *type,
 
       if (rank == 0)
 	{
-	  /* The dynamic property list juggling below was from the original
-	     patch.  I don't understand what this is all about, so I've
-	     commented it out for now and added the following error.  */
-	  error (_("failed to resolve dynamic array rank"));
+	  /* Rank is zero, if a variable is passed as an argument to a
+	     function. GDB considers the variable as an array so discard
+	     the array type and return the target type which is of variable. */
+          type->main_type->target_type->main_type->dyn_prop_list =
+                                  type->main_type->dyn_prop_list;
+          type = TYPE_TARGET_TYPE (type);
+          return type;
 	}
       else if (type->code () == TYPE_CODE_STRING && rank != 1)
 	{
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 769328cc9cd..7437e1db8ab 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -2092,7 +2092,6 @@ extern void allocate_gnat_aux_type (struct type *);
 #define TYPE_REFERENCE_TYPE(thistype) (thistype)->reference_type
 #define TYPE_RVALUE_REFERENCE_TYPE(thistype) (thistype)->rvalue_reference_type
 #define TYPE_CHAIN(thistype) (thistype)->chain
-#define TYPE_DYN_PROP(thistype)  TYPE_MAIN_TYPE(thistype)->dyn_prop_list
 /* * Note that if thistype is a TYPEDEF type, you have to call check_typedef.
    But check_typedef does set the TYPE_LENGTH of the TYPEDEF type,
    so you only have to call check_typedef once.  Since allocate_value
diff --git a/gdb/testsuite/gdb.fortran/assumedrank.exp b/gdb/testsuite/gdb.fortran/assumedrank.exp
index 69cd168125f..49b03e2f87f 100644
--- a/gdb/testsuite/gdb.fortran/assumedrank.exp
+++ b/gdb/testsuite/gdb.fortran/assumedrank.exp
@@ -14,6 +14,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/> .
 
 # Testing GDB's implementation of ASSUMED RANK arrays.
+#Until the assumed rank zero is fixed in clang, XFAIL this case for clang.
 
 if {[skip_fortran_tests]} { return -1 }
 
@@ -58,6 +59,12 @@ while { $test_count < 500 } {
 	    }
 	}
 
+	# xfail rank 0 for clang
+	if {$test_count == 1 && [test_compiler_info {clang-*}]} {
+	   xfail "clang compiler does not support rank0"
+           continue
+	}
+
 	if ($found_final_breakpoint) {
 	    break
 	}
diff --git a/gdb/testsuite/gdb.fortran/assumedrank.f90 b/gdb/testsuite/gdb.fortran/assumedrank.f90
index 7f077c3f014..7f7cf2c1f3e 100644
--- a/gdb/testsuite/gdb.fortran/assumedrank.f90
+++ b/gdb/testsuite/gdb.fortran/assumedrank.f90
@@ -19,16 +19,19 @@
 
 PROGRAM  arank
 
+  REAL :: array0
   REAL :: array1(10)
   REAL :: array2(1, 2)
   REAL :: array3(3, 4, 5)
   REAL :: array4(4, 5, 6, 7)
 
+  array0 = 0
   array1 = 1.0
   array2 = 2.0
   array3 = 3.0
   array4 = 4.0
 
+  call test_rank (array0)
   call test_rank (array1)
   call test_rank (array2)
   call test_rank (array3)
-- 
2.17.1