Re: GDB/Fortran: Support for Assumed Rank Zero.

[Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>]

Hi Rupesh,

Thanks for working on this problem.  I found a couple of nits; see
below.

On Wed, 13 Apr 2022 09:55:01 +0000
"Potharla, Rupesh via Gdb-patches" <gdb-patches@sourceware.org> wrote:

> diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
> index 49ecb199b07..c2d142ac3cc 100644
> --- a/gdb/gdbtypes.c
> +++ b/gdb/gdbtypes.c
> @@ -2398,10 +2398,12 @@ resolve_dynamic_array_or_string (struct type *type,
>  
>        if (rank == 0)
>  	{
> -	  /* The dynamic property list juggling below was from the original
> -	     patch.  I don't understand what this is all about, so I've
> -	     commented it out for now and added the following error.  */
> -	  error (_("failed to resolve dynamic array rank"));
> +	  /* Rank is zero, if a variable is passed as an argument to a
> +	     function. GDB considers the variable as an array so discard
> +	     the array type and return the target type which is of variable. */
> +          TYPE_DYN_PROP(TYPE_TARGET_TYPE(type)) = TYPE_DYN_PROP(type);
> +          type = TYPE_TARGET_TYPE(type);
> +          return type;
>  	}
>        else if (type->code () == TYPE_CODE_STRING && rank != 1)
>  	{
> 

GDB's coding standard requires that things like TYPE_TARGET_TYPE(type)
be written with a space before the left paren, i.e. TYPE_TARGET_TYPE (type).

See: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards

Also, regarding TYPE_DYN_PROP, it appears to me that this macro is no
longer being used.  I've noticed that other code in gdbtypes.c is
referencing the dyn_prop_list field directly.

Kevin